Add HTTP Request and Response Logging #380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a new logging feature for HTTP requests and responses. It adds a new abstract logger interface in the abstractions package, implements it in the HTTP package, and integrates it with the HttpxRequestAdapter. Changes: 1. Add new abstract RequestResponseLogger class 2. Implement HttpxRequestResponseLogger in HTTP package 3. Integrate logger in HttpxRequestAdapter 4. Add JSON formatting support for log messages 5. Update relevant tests Files changed: - /packages/abstractions/kiota_abstractions/request_response_logger.py (new file) - /packages/http/httpx/kiota_http/httpx_request_response_logger.py (new file) - /packages/http/httpx/kiota_http/httpx_request_adapter.py - /packages/serialization/json/kiota_serialization_json/json_serialization_writer.py - /packages/http/httpx/tests/test_httpx_request_adapter.py
|
baywet
requested changes
Oct 16, 2024
| @@ -525,6 +528,20 @@ async def get_http_response_message( | |||
|
|
|||
| self.set_base_url_for_request_information(request_info) | |||
|
|
|||
| self.logger.log_request({ | |||
There was a problem hiding this comment.
why is the logging logic here instead of in a middleware handler?
| @@ -387,6 +387,10 @@ def get_serialized_content(self) -> bytes: | |||
| stream = json_string.encode('utf-8') | |||
| return stream | |||
|
|
|||
| @staticmethod | |||
There was a problem hiding this comment.
can we avoid expanding the API surface and look into an alternative here please?
| from abc import ABC, abstractmethod | ||
| from typing import Any, Dict | ||
|
|
||
| class RequestResponseLogger(ABC): |
There was a problem hiding this comment.
could we look into an alternative that does not expand the public API surface here please?
|
I will take a look |
|
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new logging feature for HTTP requests and responses. It adds a new abstract logger interface in the abstractions package, implements it in the HTTP package, and integrates it with the HttpxRequestAdapter.
Changes:
Files changed: