Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds io.ReadCloser to request information #158

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Adds io.ReadCloser to request information #158

wants to merge 1 commit into from

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Mar 7, 2024 •
edited
Loading

Adds io.ReadCloser to request information.

Partially resolves microsoftgraph/msgraph-sdk-go#588

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rkodev rkodev mentioned this pull request Mar 7, 2024
Draft
baywet
baywet requested changes Mar 8, 2024
View reviewed changes
request_information.go
}

func (request *RequestInformation) setContentAndContentType(writer s.SerializationWriter, contentType string) error {
content, err := writer.GetSerializedContent()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect anything that's setting content to be updated to set the new field instead so implementers of request adapter can have a consistent experience here.
Alternatively, we could keep the code as-is, but add a vanity getter that'd return the reader if set, or wrap the content in a reader and return it if set.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will take a look shortly.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
conflicting
Projects
Kiota
Status: In Progress 🚧
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow streaming of file content
2 participants
@rkodev @baywet