Add .NET 9 Target #1095
Open
Add .NET 9 Target #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsugarman
added
dependencies
wsugarman
commented
Nov 20, 2024
| @@ -22,6 +22,6 @@ public static string ComputeHash(this string data) | |||
| EnsureArg.IsNotNull(data, nameof(data)); | |||
|
|
|||
| byte[] hash = SHA256.HashData(Encoding.UTF8.GetBytes(data)); | |||
| return BitConverter.ToString(hash).Replace("-", string.Empty, StringComparison.Ordinal); | |||
There was a problem hiding this comment.
BitConverter.ToString(string) returns values like AB-CD-EF-01 but Convert.ToHexString skips the - entirely
wsugarman
commented
Nov 20, 2024
| @@ -136,8 +136,8 @@ private IEnumerable<MemberDeclarationSyntax> GetPropertiesAndMethods() | |||
| .GetParameters() | |||
| .Select(p => Parameter(Identifier(p.Name)) | |||
| .WithType(p.ParameterType.ToTypeSyntax()) | |||
| .WithModifiers(p.IsDefined(typeof(ParamArrayAttribute), false) ? TokenList(Token(SyntaxKind.ParamsKeyword)) : TokenList()) | |||
| .WithOptionalAttributeLists(p.CustomAttributes)) | |||
| .WithModifiers(ParamsTokenList(p)) | |||
There was a problem hiding this comment.
These changes are to support signatures like:
public void Read(params scoped ReadOnlySpan<string> values)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the packages for .NET 9 and includes the following changes:
Related issues
N/A
Testing
Existing tests
Semver Change
Breaking