vscode: Parse settings with comments

If needed developer can revert the removed comments at the cost of loosing JSON compliance. The alternative would be to use an other non standard JSON.parse Bug: #104 Forwarded: https://github.com/Microsoft/generator-docker/pulls Change-Id: I80f8b290b846f62abaf5b99d424a8cfdfd9f84a1 Signed-off-by: Philippe Coval <[email protected]>
microsoft · Oct 25, 2019 · eeb3359 · eeb3359
1 parent 0c04637
commit eeb3359
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/generators/app/baseHelper.js b/generators/app/baseHelper.js
@@ -7,6 +7,7 @@ var util = require('./utils.js');
 var path = require('path');
 var process = require('process');
 var fs = require('fs');
+var decomment = require('decomment');
 
 /**
  * Represents a base helper for projects.
@@ -123,7 +124,7 @@ BaseHelper.prototype.updateSettingsJson = function (cb) {
                 data = data.replace(/^\uFEFF/, '');
             }
 
-            data = JSON.parse(data);
+            data = JSON.parse(decomment(data));
 
             updateSettingsCB(data, true, cb);
         });

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -25,6 +25,7 @@
   "dependencies": {
     "chalk": "^1.0.0",
     "configstore": "^1.3.0",
+    "decomment": "^0.9.2",
     "node-uuid": "^1.4.7",
     "process": "^0.11.2",
     "yeoman-generator": "^0.19.0",