-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore(web-components): Upgrade Fluent Web Components to FAST Element v3 #36351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
radium-v
wants to merge
13
commits into
microsoft:master
Choose a base branch
from
radium-v:users/radium-v/wc-upgrade-fast-v3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
41a770d
chore(web-components): upgrade to FAST Element v3 and bump build tooling
radium-v edc817d
refactor(chart-web-components): replace rollup-plugin-transform-tagge…
radium-v a40a0a7
refactor(web-components): migrate async definitions to fast-element v…
radium-v edb1081
fix timing bugs and race conditions
radium-v 5826af7
add changefiles
radium-v e27f133
fix export path for definition-async modules
radium-v dfae606
add type guard
radium-v ba002b1
revert dev dependency updates
radium-v c186662
fix version
radium-v 5a62119
update changefile
radium-v 0e453ec
revert attempts to be clever with dropdown tests
radium-v c1bbc1d
what ok I guess
radium-v e6ac78c
update api report
radium-v File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
change/@fluentui-chart-web-components-60dd95d5-d74f-488d-bd5c-3639e4e5fc02.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "chore: upgrade to FAST Element v3", | ||
| "packageName": "@fluentui/chart-web-components", | ||
| "email": "863023+radium-v@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-web-components-33e6ef9c-36bb-4072-9bea-aadda8c76bea.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "prerelease", | ||
| "comment": "refactor: migrate async definitions to fast-element v3 declarative API", | ||
| "packageName": "@fluentui/web-components", | ||
| "email": "863023+radium-v@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 6 additions & 4 deletions
10
packages/web-components/src/accordion-item/accordion-item.definition-async.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,17 @@ | ||
| import type { PartialFASTElementDefinition } from '@microsoft/fast-element'; | ||
| import { declarativeTemplate, type PartialFASTElementDefinition } from '@microsoft/fast-element/declarative.js'; | ||
| import { FluentDesignSystem } from '../fluent-design-system.js'; | ||
| import { tagName } from './accordion-item.options.js'; | ||
|
|
||
| /** | ||
| * The async definition configuration for the fluent-accordion-item element. | ||
| * The async definition configuration for the `<fluent-accordion-item>` element. | ||
| * | ||
| * @public | ||
| * @remarks | ||
| * This is used in server-side rendering (SSR) scenarios where the template | ||
| * is provided as a deferred option to be hydrated later. | ||
| */ | ||
| export const definition: PartialFASTElementDefinition = { | ||
| export const declarativeDefinition: PartialFASTElementDefinition = { | ||
| name: tagName, | ||
| templateOptions: 'defer-and-hydrate', | ||
| registry: FluentDesignSystem.registry, | ||
| template: declarativeTemplate(), | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import { RenderableFASTElement } from '@microsoft/fast-html'; | ||
| import { definition } from './accordion-item.definition-async.js'; | ||
| import { declarativeDefinition } from './accordion-item.definition-async.js'; | ||
| import { AccordionItem } from './accordion-item.js'; | ||
|
|
||
| RenderableFASTElement(AccordionItem).defineAsync(definition); | ||
| AccordionItem.define(declarativeDefinition); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import { RenderableFASTElement } from '@microsoft/fast-html'; | ||
| import { declarativeDefinition } from './accordion.definition-async.js'; | ||
| import { Accordion } from './accordion.js'; | ||
|
|
||
| RenderableFASTElement(Accordion).defineAsync(declarativeDefinition); | ||
| Accordion.define(declarativeDefinition); |
10 changes: 6 additions & 4 deletions
10
packages/web-components/src/anchor-button/anchor-button.definition-async.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,17 @@ | ||
| import type { PartialFASTElementDefinition } from '@microsoft/fast-element'; | ||
| import { declarativeTemplate, type PartialFASTElementDefinition } from '@microsoft/fast-element/declarative.js'; | ||
| import { FluentDesignSystem } from '../fluent-design-system.js'; | ||
| import { tagName } from './anchor-button.options.js'; | ||
|
|
||
| /** | ||
| * The async definition configuration for the fluent-anchor-button element. | ||
| * The async definition configuration for the `<fluent-anchor-button>` element. | ||
| * | ||
| * @public | ||
| * @remarks | ||
| * This is used in server-side rendering (SSR) scenarios where the template | ||
| * is provided as a deferred option to be hydrated later. | ||
| */ | ||
| export const definition: PartialFASTElementDefinition = { | ||
| export const declarativeDefinition: PartialFASTElementDefinition = { | ||
| name: tagName, | ||
| templateOptions: 'defer-and-hydrate', | ||
| registry: FluentDesignSystem.registry, | ||
| template: declarativeTemplate(), | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import { RenderableFASTElement } from '@microsoft/fast-html'; | ||
| import { definition } from './anchor-button.definition-async.js'; | ||
| import { declarativeDefinition } from './anchor-button.definition-async.js'; | ||
| import { AnchorButton } from './anchor-button.js'; | ||
|
|
||
| RenderableFASTElement(AnchorButton).defineAsync(definition); | ||
| AnchorButton.define(declarativeDefinition); |
10 changes: 6 additions & 4 deletions
10
packages/web-components/src/avatar/avatar.definition-async.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,17 @@ | ||
| import type { PartialFASTElementDefinition } from '@microsoft/fast-element'; | ||
| import { declarativeTemplate, type PartialFASTElementDefinition } from '@microsoft/fast-element/declarative.js'; | ||
| import { FluentDesignSystem } from '../fluent-design-system.js'; | ||
| import { tagName } from './avatar.options.js'; | ||
|
|
||
| /** | ||
| * The async definition configuration for the fluent-avatar element. | ||
| * The async definition configuration for the `<fluent-avatar>` element. | ||
| * | ||
| * @public | ||
| * @remarks | ||
| * This is used in server-side rendering (SSR) scenarios where the template | ||
| * is provided as a deferred option to be hydrated later. | ||
| */ | ||
| export const definition: PartialFASTElementDefinition = { | ||
| export const declarativeDefinition: PartialFASTElementDefinition = { | ||
| name: tagName, | ||
| templateOptions: 'defer-and-hydrate', | ||
| registry: FluentDesignSystem.registry, | ||
| template: declarativeTemplate(), | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import { RenderableFASTElement } from '@microsoft/fast-html'; | ||
| import { definition } from './avatar.definition-async.js'; | ||
| import { declarativeDefinition } from './avatar.definition-async.js'; | ||
| import { Avatar } from './avatar.js'; | ||
|
|
||
| RenderableFASTElement(Avatar).defineAsync(definition); | ||
| Avatar.define(declarativeDefinition); |
10 changes: 6 additions & 4 deletions
10
packages/web-components/src/badge/badge.definition-async.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,17 @@ | ||
| import type { PartialFASTElementDefinition } from '@microsoft/fast-element'; | ||
| import { declarativeTemplate, type PartialFASTElementDefinition } from '@microsoft/fast-element/declarative.js'; | ||
| import { FluentDesignSystem } from '../fluent-design-system.js'; | ||
| import { tagName } from './badge.options.js'; | ||
|
|
||
| /** | ||
| * The async definition configuration for the fluent-badge element. | ||
| * The async definition configuration for the `<fluent-badge>` element. | ||
| * | ||
| * @public | ||
| * @remarks | ||
| * This is used in server-side rendering (SSR) scenarios where the template | ||
| * is provided as a deferred option to be hydrated later. | ||
| */ | ||
| export const definition: PartialFASTElementDefinition = { | ||
| export const declarativeDefinition: PartialFASTElementDefinition = { | ||
| name: tagName, | ||
| templateOptions: 'defer-and-hydrate', | ||
| registry: FluentDesignSystem.registry, | ||
| template: declarativeTemplate(), | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import { RenderableFASTElement } from '@microsoft/fast-html'; | ||
| import { definition } from './badge.definition-async.js'; | ||
| import { declarativeDefinition } from './badge.definition-async.js'; | ||
| import { Badge } from './badge.js'; | ||
|
|
||
| RenderableFASTElement(Badge).defineAsync(definition); | ||
| Badge.define(declarativeDefinition); |
10 changes: 6 additions & 4 deletions
10
packages/web-components/src/button/button.definition-async.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,17 @@ | ||
| import type { PartialFASTElementDefinition } from '@microsoft/fast-element'; | ||
| import { declarativeTemplate, type PartialFASTElementDefinition } from '@microsoft/fast-element/declarative.js'; | ||
| import { FluentDesignSystem } from '../fluent-design-system.js'; | ||
| import { tagName } from './button.options.js'; | ||
|
|
||
| /** | ||
| * The async definition configuration for the fluent-button element. | ||
| * The async definition configuration for the `<fluent-button>` element. | ||
| * | ||
| * @public | ||
| * @remarks | ||
| * This is used in server-side rendering (SSR) scenarios where the template | ||
| * is provided as a deferred option to be hydrated later. | ||
| */ | ||
| export const definition: PartialFASTElementDefinition = { | ||
| export const declarativeDefinition: PartialFASTElementDefinition = { | ||
| name: tagName, | ||
| templateOptions: 'defer-and-hydrate', | ||
| registry: FluentDesignSystem.registry, | ||
| template: declarativeTemplate(), | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import { RenderableFASTElement } from '@microsoft/fast-html'; | ||
| import { definition } from './button.definition-async.js'; | ||
| import { declarativeDefinition } from './button.definition-async.js'; | ||
| import { Button } from './button.js'; | ||
|
|
||
| RenderableFASTElement(Button).defineAsync(definition); | ||
| Button.define(declarativeDefinition); |
10 changes: 6 additions & 4 deletions
10
packages/web-components/src/checkbox/checkbox.definition-async.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,17 @@ | ||
| import type { PartialFASTElementDefinition } from '@microsoft/fast-element'; | ||
| import { declarativeTemplate, type PartialFASTElementDefinition } from '@microsoft/fast-element/declarative.js'; | ||
| import { FluentDesignSystem } from '../fluent-design-system.js'; | ||
| import { tagName } from './checkbox.options.js'; | ||
|
|
||
| /** | ||
| * The async definition configuration for the fluent-checkbox element. | ||
| * The async definition configuration for the `<fluent-checkbox>` element. | ||
| * | ||
| * @public | ||
| * @remarks | ||
| * This is used in server-side rendering (SSR) scenarios where the template | ||
| * is provided as a deferred option to be hydrated later. | ||
| */ | ||
| export const definition: PartialFASTElementDefinition = { | ||
| export const declarativeDefinition: PartialFASTElementDefinition = { | ||
| name: tagName, | ||
| templateOptions: 'defer-and-hydrate', | ||
| registry: FluentDesignSystem.registry, | ||
| template: declarativeTemplate(), | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import { RenderableFASTElement } from '@microsoft/fast-html'; | ||
| import { definition } from './checkbox.definition-async.js'; | ||
| import { declarativeDefinition } from './checkbox.definition-async.js'; | ||
| import { Checkbox } from './checkbox.js'; | ||
|
|
||
| RenderableFASTElement(Checkbox).defineAsync(definition); | ||
| Checkbox.define(declarativeDefinition); |
10 changes: 6 additions & 4 deletions
10
packages/web-components/src/compound-button/compound-button.definition-async.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,17 @@ | ||
| import type { PartialFASTElementDefinition } from '@microsoft/fast-element'; | ||
| import { declarativeTemplate, type PartialFASTElementDefinition } from '@microsoft/fast-element/declarative.js'; | ||
| import { FluentDesignSystem } from '../fluent-design-system.js'; | ||
| import { tagName } from './compound-button.options.js'; | ||
|
|
||
| /** | ||
| * The async definition configuration for the fluent-compound-button element. | ||
| * The async definition configuration for the `<fluent-compound-button>` element. | ||
| * | ||
| * @public | ||
| * @remarks | ||
| * This is used in server-side rendering (SSR) scenarios where the template | ||
| * is provided as a deferred option to be hydrated later. | ||
| */ | ||
| export const definition: PartialFASTElementDefinition = { | ||
| export const declarativeDefinition: PartialFASTElementDefinition = { | ||
| name: tagName, | ||
| templateOptions: 'defer-and-hydrate', | ||
| registry: FluentDesignSystem.registry, | ||
| template: declarativeTemplate(), | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import { RenderableFASTElement } from '@microsoft/fast-html'; | ||
| import { definition } from './compound-button.definition-async.js'; | ||
| import { declarativeDefinition } from './compound-button.definition-async.js'; | ||
| import { CompoundButton } from './compound-button.js'; | ||
|
|
||
| RenderableFASTElement(CompoundButton).defineAsync(definition); | ||
| CompoundButton.define(declarativeDefinition); |
10 changes: 6 additions & 4 deletions
10
packages/web-components/src/counter-badge/counter-badge.definition-async.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,17 @@ | ||
| import type { PartialFASTElementDefinition } from '@microsoft/fast-element'; | ||
| import { declarativeTemplate, type PartialFASTElementDefinition } from '@microsoft/fast-element/declarative.js'; | ||
| import { FluentDesignSystem } from '../fluent-design-system.js'; | ||
| import { tagName } from './counter-badge.options.js'; | ||
|
|
||
| /** | ||
| * The async definition configuration for the fluent-counter-badge element. | ||
| * The async definition configuration for the `<fluent-counter-badge>` element. | ||
| * | ||
| * @public | ||
| * @remarks | ||
| * This is used in server-side rendering (SSR) scenarios where the template | ||
| * is provided as a deferred option to be hydrated later. | ||
| */ | ||
| export const definition: PartialFASTElementDefinition = { | ||
| export const declarativeDefinition: PartialFASTElementDefinition = { | ||
| name: tagName, | ||
| templateOptions: 'defer-and-hydrate', | ||
| registry: FluentDesignSystem.registry, | ||
| template: declarativeTemplate(), | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import { RenderableFASTElement } from '@microsoft/fast-html'; | ||
| import { definition } from './counter-badge.definition-async.js'; | ||
| import { declarativeDefinition } from './counter-badge.definition-async.js'; | ||
| import { CounterBadge } from './counter-badge.js'; | ||
|
|
||
| RenderableFASTElement(CounterBadge).defineAsync(definition); | ||
| CounterBadge.define(declarativeDefinition); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import { RenderableFASTElement } from '@microsoft/fast-html'; | ||
| import { definition } from './dialog-body.definition-async.js'; | ||
| import { declarativeDefinition } from './dialog-body.definition-async.js'; | ||
| import { DialogBody } from './dialog-body.js'; | ||
|
|
||
| RenderableFASTElement(DialogBody).defineAsync(definition); | ||
| DialogBody.define(declarativeDefinition); |
10 changes: 6 additions & 4 deletions
10
packages/web-components/src/dialog-body/dialog-body.definition-async.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,17 @@ | ||
| import type { PartialFASTElementDefinition } from '@microsoft/fast-element'; | ||
| import { declarativeTemplate, type PartialFASTElementDefinition } from '@microsoft/fast-element/declarative.js'; | ||
| import { FluentDesignSystem } from '../fluent-design-system.js'; | ||
| import { tagName } from './dialog-body.options.js'; | ||
|
|
||
| /** | ||
| * The async definition configuration for the fluent-dialog-body element. | ||
| * The async definition configuration for the `<fluent-dialog-body>` element. | ||
| * | ||
| * @public | ||
| * @remarks | ||
| * This is used in server-side rendering (SSR) scenarios where the template | ||
| * is provided as a deferred option to be hydrated later. | ||
| */ | ||
| export const definition: PartialFASTElementDefinition = { | ||
| export const declarativeDefinition: PartialFASTElementDefinition = { | ||
| name: tagName, | ||
| templateOptions: 'defer-and-hydrate', | ||
| registry: FluentDesignSystem.registry, | ||
| template: declarativeTemplate(), | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import { RenderableFASTElement } from '@microsoft/fast-html'; | ||
| import { definition } from './dialog.definition-async.js'; | ||
| import { declarativeDefinition } from './dialog.definition-async.js'; | ||
| import { Dialog } from './dialog.js'; | ||
|
|
||
| RenderableFASTElement(Dialog).defineAsync(definition); | ||
| Dialog.define(declarativeDefinition); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
vr-tests-react-components/Positioning 2 screenshots
vr-tests-react-components/ProgressBar converged 3 screenshots
vr-tests-react-components/Skeleton converged 1 screenshots
vr-tests-react-components/TagPicker 3 screenshots
vr-tests-web-components/Accordion 7 screenshots
vr-tests-web-components/Avatar 1 screenshots
vr-tests-web-components/Button 10 screenshots
vr-tests-web-components/Divider 1 screenshots
vr-tests-web-components/Label 4 screenshots
vr-tests-web-components/MenuList 5 screenshots
vr-tests-web-components/RadioGroup 2 screenshots
vr-tests-web-components/Slider 4 screenshots
vr-tests-web-components/Text 9 screenshots
vr-tests-web-components/TextInput 1 screenshots
vr-tests/react-charting-LineChart 1 screenshots
There were 10 duplicate changes discarded. Check the build logs for more information.