Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent pixel-fraction overflow from v8 TextField focus indicator #31314

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: prevent pixel-fraction overflow from v8 TextField focus indicator #31314

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
361c5e4
fix: prevent pixel-fraction overflow from TextField focus indicator
smhigley May 8, 2024
a195277
change file
smhigley May 8, 2024
8b5d0a0
update snapshots
smhigley May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-a80addea-99f6-4096-9383-b0b193004086.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Copy link
Collaborator

@fabricteam fabricteam May 8, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentuiv8 Open the Visual Regressions report to inspect the affected screenshots

DatePicker 10 screenshots
Image Name Diff(in Pixels) Image Type
DatePicker.Required.hover datepicker.chromium.png 7 Changed
DatePicker.Required.default.chromium.png 7 Changed
DatePicker.Underlined and Required.default.chromium.png 7 Changed
DatePicker.Underlined and Required.hover datepicker.chromium.png 7 Changed
DatePicker.Required.hover day.chromium.png 7 Changed
DatePicker.Required.hover month.chromium.png 7 Changed
DatePicker.Required.click.chromium.png 7 Changed
DatePicker.Underlined and Required.click.chromium.png 7 Changed
DatePicker.Underlined and Required.hover month.chromium.png 7 Changed
DatePicker.Underlined and Required.hover day.chromium.png 7 Changed
TextField 13 screenshots
Image Name Diff(in Pixels) Image Type
TextField.Multiline nonresizable.click.chromium.png 2 Changed
TextField.Multiline.click.chromium.png 2 Changed
TextField.Suffix.click.chromium.png 2 Changed
TextField.Error - RTL.click.chromium.png 2 Changed
TextField.Icon - RTL.click.chromium.png 2 Changed
TextField.Placeholder - RTL.click.chromium.png 2 Changed
TextField.Error.click.chromium.png 2 Changed
TextField.Placeholder.click.chromium.png 2 Changed
TextField.Icon.click.chromium.png 2 Changed
TextField.Root.click.chromium.png 2 Changed
TextField.Required.click.chromium.png 2 Changed
TextField.Multiline - RTL.click.chromium.png 2 Changed
TextField.Suffix - RTL.click.chromium.png 2 Changed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no, looks like the required asterisk renders outside and having overflow hidden hides it 😅

"type": "patch",
"comment": "fix: prevent pixel-fraction overflow from TextField focus indicator",
"packageName": "@fluentui/react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions packages/react/src/components/TextField/TextField.styles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ export function getStyles(props: ITextFieldStyleProps): ITextFieldStyles {
flexDirection: 'row',
alignItems: 'stretch',
position: 'relative',
overflow: 'hidden',
},
multiline && {
minHeight: '60px',
Expand Down