Coachmark (v8): convert tests to use testing-library #22242
Conversation
| ); | ||
|
|
||
| const coachmark = getByRole('dialog', { hidden: true }); |
There was a problem hiding this comment.
Needed hidden:true option since dialog role is inaccessible here because the element containing that role has a parent wrapper with role=presentation when the Coachmark is not collapsed.
There was a problem hiding this comment.
Interesting, I wonder if that's an actual a11y problem? Regardless would be good to note that in a comment in the file.
| ); | ||
|
|
||
| const coachmark = getByRole('dialog', { hidden: true }); |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 557da66:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 062d979198fe559cb476660fdeb4d94a6e2d09cc (build) |
📊 Bundle size report🤖 This report was generated against 062d979198fe559cb476660fdeb4d94a6e2d09cc |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1072 | 1055 | 5000 | |
| Breadcrumb | mount | 2912 | 2921 | 1000 | |
| Checkbox | mount | 1715 | 1731 | 5000 | |
| CheckboxBase | mount | 1456 | 1499 | 5000 | |
| ChoiceGroup | mount | 5263 | 5415 | 5000 | |
| ComboBox | mount | 1043 | 1187 | 1000 | |
| CommandBar | mount | 11140 | 11087 | 1000 | |
| ContextualMenu | mount | 12365 | 12526 | 1000 | |
| DefaultButton | mount | 1337 | 1327 | 5000 | |
| DetailsRow | mount | 4245 | 4268 | 5000 | |
| DetailsRowFast | mount | 4379 | 4252 | 5000 | |
| DetailsRowNoStyles | mount | 4133 | 4078 | 5000 | |
| Dialog | mount | 2363 | 2385 | 1000 | |
| DocumentCardTitle | mount | 164 | 184 | 1000 | |
| Dropdown | mount | 3651 | 3722 | 5000 | |
| FocusTrapZone | mount | 1922 | 1924 | 5000 | |
| FocusZone | mount | 1924 | 1906 | 5000 | |
| IconButton | mount | 1950 | 2096 | 5000 | |
| Label | mount | 396 | 399 | 5000 | |
| Layer | mount | 3292 | 3329 | 5000 | |
| Link | mount | 519 | 558 | 5000 | |
| MenuButton | mount | 1738 | 1727 | 5000 | |
| MessageBar | mount | 2252 | 2346 | 5000 | |
| Nav | mount | 3726 | 3655 | 1000 | |
| OverflowSet | mount | 1260 | 1207 | 5000 | |
| Panel | mount | 2308 | 2354 | 1000 | |
| Persona | mount | 1165 | 1120 | 1000 | |
| Pivot | mount | 1558 | 1609 | 1000 | |
| PrimaryButton | mount | 1499 | 1470 | 5000 | |
| Rating | mount | 8908 | 8921 | 5000 | |
| SearchBox | mount | 1556 | 1528 | 5000 | |
| Shimmer | mount | 2819 | 2860 | 5000 | |
| Slider | mount | 2174 | 2160 | 5000 | |
| SpinButton | mount | 5531 | 5549 | 5000 | |
| Spinner | mount | 459 | 478 | 5000 | |
| SplitButton | mount | 3526 | 3565 | 5000 | |
| Stack | mount | 599 | 586 | 5000 | |
| StackWithIntrinsicChildren | mount | 2843 | 2699 | 5000 | |
| StackWithTextChildren | mount | 6318 | 6230 | 5000 | |
| SwatchColorPicker | mount | 12608 | 12881 | 5000 | |
| TagPicker | mount | 2979 | 3058 | 5000 | |
| TeachingBubble | mount | 106448 | 108021 | 5000 | |
| Text | mount | 509 | 503 | 5000 | |
| TextField | mount | 1622 | 1609 | 5000 | |
| ThemeProvider | mount | 1270 | 1265 | 5000 | |
| ThemeProvider | virtual-rerender | 685 | 708 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2046 | 2052 | 5000 | |
| Toggle | mount | 888 | 897 | 5000 | |
| buttonNative | mount | 146 | 165 | 5000 |
| ); | ||
|
|
||
| const coachmark = getByRole('dialog', { hidden: true }); |
There was a problem hiding this comment.
Interesting, I wonder if that's an actual a11y problem? Regardless would be good to note that in a comment in the file.
Current Behavior
Coachmarktests don't use testing-libraryNew Behavior
Coachmarkto fully use testing-libraryRelated Issue(s)
part of #21663