-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextField (v8): convert tests to use testing-library #21990
TextField (v8): convert tests to use testing-library #21990
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit baf1b23:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d88aa37edfa3332770f832d05b021cb96c353c96 (build) |
📊 Bundle size report🤖 This report was generated against d88aa37edfa3332770f832d05b021cb96c353c96 |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 776 | 789 | 5000 | |
Breadcrumb | mount | 2290 | 2332 | 1000 | |
Checkbox | mount | 1272 | 1318 | 5000 | |
CheckboxBase | mount | 1113 | 1094 | 5000 | |
ChoiceGroup | mount | 4071 | 4053 | 5000 | |
ComboBox | mount | 850 | 833 | 1000 | |
CommandBar | mount | 8934 | 8974 | 1000 | |
ContextualMenu | mount | 10095 | 10349 | 1000 | |
DefaultButton | mount | 991 | 984 | 5000 | |
DetailsRow | mount | 3276 | 3274 | 5000 | |
DetailsRowFast | mount | 3268 | 3241 | 5000 | |
DetailsRowNoStyles | mount | 3180 | 3083 | 5000 | |
Dialog | mount | 1937 | 1891 | 1000 | |
DocumentCardTitle | mount | 145 | 138 | 1000 | |
Dropdown | mount | 2853 | 2859 | 5000 | |
FocusTrapZone | mount | 1569 | 1547 | 5000 | |
FocusZone | mount | 1585 | 1548 | 5000 | |
IconButton | mount | 1501 | 1522 | 5000 | |
Label | mount | 315 | 315 | 5000 | |
Layer | mount | 2582 | 2551 | 5000 | |
Link | mount | 402 | 397 | 5000 | |
MenuButton | mount | 1244 | 1275 | 5000 | |
MessageBar | mount | 1885 | 1785 | 5000 | |
Nav | mount | 2863 | 2850 | 1000 | |
OverflowSet | mount | 933 | 956 | 5000 | |
Panel | mount | 1837 | 1876 | 1000 | |
Persona | mount | 733 | 741 | 1000 | |
Pivot | mount | 1291 | 1249 | 1000 | |
PrimaryButton | mount | 1121 | 1122 | 5000 | |
Rating | mount | 6738 | 6633 | 5000 | |
SearchBox | mount | 1125 | 1108 | 5000 | |
Shimmer | mount | 2162 | 2140 | 5000 | |
Slider | mount | 1671 | 1722 | 5000 | |
SpinButton | mount | 4296 | 4298 | 5000 | |
Spinner | mount | 385 | 375 | 5000 | |
SplitButton | mount | 2736 | 2757 | 5000 | |
Stack | mount | 439 | 447 | 5000 | |
StackWithIntrinsicChildren | mount | 1997 | 1958 | 5000 | |
StackWithTextChildren | mount | 4511 | 4500 | 5000 | |
SwatchColorPicker | mount | 10832 | 10051 | 5000 | |
TagPicker | mount | 2342 | 2307 | 5000 | |
TeachingBubble | mount | 87110 | 85292 | 5000 | |
Text | mount | 362 | 369 | 5000 | |
TextField | mount | 1213 | 1202 | 5000 | |
ThemeProvider | mount | 1005 | 1013 | 5000 | |
ThemeProvider | virtual-rerender | 563 | 552 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1586 | 1604 | 5000 | |
Toggle | mount | 690 | 696 | 5000 | |
buttonNative | mount | 93 | 116 | 5000 |
Current Behavior
TextField
tests don't use testing-libraryNew Behavior
TextField
to fully use testing-libraryRelated Issue(s)
part of #21663