-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkbox (v8): convert tests to use testing-library #21968
Checkbox (v8): convert tests to use testing-library #21968
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit afa9ab3:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9d0611016f1e6f5a39b105df1d6e85beecb1e469 (build) |
📊 Bundle size report🤖 This report was generated against 9d0611016f1e6f5a39b105df1d6e85beecb1e469 |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
StackWithTextChildren | mount | 4810 | 4780 | 5000 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 966 | 922 | 5000 | |
BaseButton | mount | 1019 | 1001 | 5000 | |
Breadcrumb | mount | 2680 | 2716 | 1000 | |
ButtonNext | mount | 617 | 630 | 5000 | |
Checkbox | mount | 1529 | 1480 | 5000 | |
CheckboxBase | mount | 1329 | 1301 | 5000 | |
ChoiceGroup | mount | 4318 | 4322 | 5000 | |
ComboBox | mount | 1076 | 1108 | 1000 | |
CommandBar | mount | 9511 | 9286 | 1000 | |
ContextualMenu | mount | 14784 | 15184 | 1000 | |
DefaultButton | mount | 1169 | 1178 | 5000 | |
DetailsRow | mount | 3473 | 3551 | 5000 | |
DetailsRowFast | mount | 3482 | 3509 | 5000 | |
DetailsRowNoStyles | mount | 3387 | 3336 | 5000 | |
Dialog | mount | 2112 | 2127 | 1000 | |
DocumentCardTitle | mount | 306 | 310 | 1000 | |
Dropdown | mount | 3037 | 3022 | 5000 | |
FluentProviderNext | mount | 2048 | 2085 | 5000 | |
FluentProviderWithTheme | mount | 333 | 347 | 10 | |
FluentProviderWithTheme | virtual-rerender | 280 | 281 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 353 | 363 | 10 | |
FocusTrapZone | mount | 1774 | 1781 | 5000 | |
FocusZone | mount | 1746 | 1777 | 5000 | |
IconButton | mount | 1719 | 1692 | 5000 | |
Label | mount | 522 | 494 | 5000 | |
Layer | mount | 2785 | 2796 | 5000 | |
Link | mount | 603 | 609 | 5000 | |
MakeStyles | mount | 1625 | 1640 | 50000 | |
MenuButton | mount | 1500 | 1470 | 5000 | |
MessageBar | mount | 1921 | 1968 | 5000 | |
Nav | mount | 3070 | 3033 | 1000 | |
OverflowSet | mount | 1144 | 1154 | 5000 | |
Panel | mount | 2051 | 2030 | 1000 | |
Persona | mount | 927 | 910 | 1000 | |
Pivot | mount | 1455 | 1538 | 1000 | |
PrimaryButton | mount | 1286 | 1301 | 5000 | |
Rating | mount | 6928 | 6865 | 5000 | |
SearchBox | mount | 1357 | 1321 | 5000 | |
Shimmer | mount | 2391 | 2375 | 5000 | |
Slider | mount | 1895 | 1887 | 5000 | |
SpinButton | mount | 4631 | 4621 | 5000 | |
Spinner | mount | 565 | 568 | 5000 | |
SplitButton | mount | 2981 | 2942 | 5000 | |
Stack | mount | 652 | 669 | 5000 | |
StackWithIntrinsicChildren | mount | 2260 | 2255 | 5000 | |
StackWithTextChildren | mount | 4810 | 4780 | 5000 | Possible regression |
SwatchColorPicker | mount | 10335 | 10398 | 5000 | |
TagPicker | mount | 2473 | 2497 | 5000 | |
TeachingBubble | mount | 11608 | 11658 | 5000 | |
Text | mount | 561 | 548 | 5000 | |
TextField | mount | 1430 | 1406 | 5000 | |
ThemeProvider | mount | 1176 | 1208 | 5000 | |
ThemeProvider | virtual-rerender | 699 | 747 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1797 | 1776 | 5000 | |
Toggle | mount | 884 | 867 | 5000 | |
buttonNative | mount | 333 | 291 | 5000 |
Current Behavior
Checkbox
tests don't use testing-libraryNew Behavior
Checkbox
to fully use testing-libraryRelated Issue(s)
part of #21663