-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(macOS Button): Use Fluent 2 alias tokens #3778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"and that our jest tests are actually testing that on macOS." -- I think right now our jest tests only run on one platform at a time, so we kinda have to pick which platform we want tested. |
rurikoaraki
reviewed
Oct 7, 2024
rurikoaraki
reviewed
Oct 7, 2024
rurikoaraki
approved these changes
Oct 8, 2024
Moving back to draft, as I am making updates to the token definitions |
Token definition updates blocked upstream. Merging as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
The macOS Button color tokens were still being set by older, deprecated tokens instead of the Fluent-2-vetted alias tokens. Let's update them.
Notable changes and things I learned (though I probably missed a few):
Followups:
Verification
Video of how the buttons look now.
Screen.Recording.2024-10-16.at.3.44.39.PM.mov
Pull request checklist
This PR has considered (when applicable):