Button tokens was missing iOS File and had a typo in Default file #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3590116.
The color tokens file for iOS was missing, and the default one had a couple of types (icon: instead of iconColor:)
rurikoaraki
reviewed
Nov 16, 2023
|
|
||
| export const defaultButtonColorTokens: TokenSettings<ButtonTokens, Theme> = (t: Theme) => | ||
| ({ | ||
| backgroundColor: t.colors.buttonBackground, |
There was a problem hiding this comment.
Is this a copy of the base ButtinColorTokens file? If so this file isn't necessary, it should pick up the base version if no override has been specified.
There was a problem hiding this comment.
let me check that, I actually noticed this was missing and the bugs in the other one several weeks ago then forgot to go through with the check in so I'm resurecting it.
There was a problem hiding this comment.
If you do need iOS tokens, we should use Fluent tokens to specify the styling. The current colors listed here are older colors that aren't used in the Fluent2 system.
|
Please add a description of your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
(a summary of the changes made, often organized by file)
Verification
ran local tests and test code
Pull request checklist
This PR has considered (when applicable):