Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Spinner test #2836

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ayush547
Copy link
Contributor

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Spinner test was incomplete in nature, completed it.

Verification

(how the change was tested, including both manual and automated tests)

Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@ayush547 ayush547 requested a review from a team as a code owner May 22, 2023 09:58
Copy link
Collaborator

@Saadnajmi Saadnajmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@rohanprasadofficial
Copy link
Contributor

The build won't pass until we fix Spinner on android.

I will have these changes as part of the fix for Spinner on Android

Copy link

@niiks3 niiks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@Saadnajmi
Copy link
Collaborator

Saadnajmi commented Oct 21, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Saadnajmi
Copy link
Collaborator

The added test seems to fail..

@niiks3
Copy link

niiks3 commented Oct 30, 2023

True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants