[Text] Fix text not wrapping #2742
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 20130c2.
| @@ -21,7 +21,7 @@ function onChangeUncontrolled(_e: InteractionEvent, isChecked: boolean) { | |||
| const BasicCheckbox: React.FunctionComponent = () => { | |||
| return ( | |||
| <View> | |||
| <Checkbox label="Unchecked checkbox (undefined)" onChange={onChangeUncontrolled} /> | |||
| <Checkbox label="Unchecked checkbox (undefined) aidasdijk ahsdihsaidhas jasdhasid" onChange={onChangeUncontrolled} /> | |||
There was a problem hiding this comment.
I think we should leave the previous text only.
As we have already done our testing, this is not required for tester.
There was a problem hiding this comment.
Or may be add a bigger valid(meaningful) string?
| @@ -96,6 +96,7 @@ export const Text = compressible<TextProps, TextTokens>((props: TextProps, useTo | |||
| // now build the text style from tokens that can be shared between different Text instances | |||
| const [tokenStyle] = cache( | |||
| () => ({ | |||
| flexShrink: 1, // Fixes bug in RN where text does not wrap correctly. RN bug #1438 | |||
There was a problem hiding this comment.
I am wondering why Checkbox and Switch snapshot didn't change as they have used the Text same as Radio.
If we have redundant flexShrink:1 on Checkbox and Switch , please remove that from there and let's have it on Text only.
| @@ -138,7 +139,8 @@ export const Text = compressible<TextProps, TextTokens>((props: TextProps, useTo | |||
|
|
|||
| // return a continuation function that allows this text to be compressed | |||
| return (extra: TextProps, children: React.ReactNode) => { | |||
| const mergedProps = { | |||
| const mergedProps: TextProps = { | |||
| accessibilityRole: 'text', | |||
There was a problem hiding this comment.
this is good addition. 👍
There was a problem hiding this comment.
missed this, same fix was made for Switch for accessibility issue here: #2644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
This PR fixes that.
(FlexShrink property was added to fix this, it is till overridable through props)
Verification
Android developer option - Layout Bounds has been enabled for better visualization.
Pull request checklist
This PR has considered (when applicable):