Skip to content

Commit

Permalink
Fix broken links & update cookie (#3805)
Browse files Browse the repository at this point in the history
* Fix links

* Yarn dedupe

* Update cookie
  • Loading branch information
rurikoaraki authored Oct 29, 2024
1 parent c183fab commit 277f9c0
Show file tree
Hide file tree
Showing 3 changed files with 74 additions and 884 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This guide assumes you:

- Have read through the [React Native Docs](https://reactnative.dev/docs/getting-started). In particular:
- Understand classes vs function components (we use the latter) and [hooks](https://reactjs.org/docs/hooks-intro.html). Here's a good [video](https://www.youtube.com/watch?v=dpw9EHDh2bM) that explains function components and hooks for traditional OOP developers.
- Understand [Native Modules](https://reactnative.dev/docs/native-modules-ios).
- Understand [Native Modules](https://reactnative.dev/docs/0.74/native-modules-intro).
- Have a local fork of FluentUI React Native and have run the test app.

## Understanding the Repository Structure
Expand Down Expand Up @@ -82,7 +82,7 @@ Reach out to Samuel Freiberg with any questions related to E2E testing.

## Adding native code to your new component

Through the power of [Native Modules](https://reactnative.dev/docs/native-modules-intro), we are able to create components that are comprised of native platform code, rather than JS. This is particularly useful if you want platform specific behavior, or if you want a component that feels much more aligned to it's specific platform. The downside is you must implement the Native module for every platform you wish to support. It's worth investigating whether you truly need a native module, or if a more cross platform JS implementation is the better approach.
Through the power of [Native Modules](https://reactnative.dev/docs/0.74/native-modules-intro), we are able to create components that are comprised of native platform code, rather than JS. This is particularly useful if you want platform specific behavior, or if you want a component that feels much more aligned to it's specific platform. The downside is you must implement the Native module for every platform you wish to support. It's worth investigating whether you truly need a native module, or if a more cross platform JS implementation is the better approach.

There are a few caveats to know of adding a native module to a FluentUI React Native component:

Expand Down
16 changes: 8 additions & 8 deletions tester_deps/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2332,10 +2332,10 @@ __metadata:
languageName: node
linkType: hard

"cookie@npm:0.6.0":
version: 0.6.0
resolution: "cookie@npm:0.6.0"
checksum: 10c0/f2318b31af7a31b4ddb4a678d024514df5e705f9be5909a192d7f116cfb6d45cbacf96a473fa733faa95050e7cff26e7832bb3ef94751592f1387b71c8956686
"cookie@npm:0.7.1":
version: 0.7.1
resolution: "cookie@npm:0.7.1"
checksum: 10c0/5de60c67a410e7c8dc8a46a4b72eb0fe925871d057c9a5d2c0e8145c4270a4f81076de83410c4d397179744b478e33cd80ccbcc457abf40a9409ad27dcd21dde
languageName: node
linkType: hard

Expand Down Expand Up @@ -2998,15 +2998,15 @@ __metadata:
linkType: hard

"express@npm:^4.19.2":
version: 4.21.0
resolution: "express@npm:4.21.0"
version: 4.21.1
resolution: "express@npm:4.21.1"
dependencies:
accepts: "npm:~1.3.8"
array-flatten: "npm:1.1.1"
body-parser: "npm:1.20.3"
content-disposition: "npm:0.5.4"
content-type: "npm:~1.0.4"
cookie: "npm:0.6.0"
cookie: "npm:0.7.1"
cookie-signature: "npm:1.0.6"
debug: "npm:2.6.9"
depd: "npm:2.0.0"
Expand All @@ -3032,7 +3032,7 @@ __metadata:
type-is: "npm:~1.6.18"
utils-merge: "npm:1.0.1"
vary: "npm:~1.1.2"
checksum: 10c0/4cf7ca328f3fdeb720f30ccb2ea7708bfa7d345f9cc460b64a82bf1b2c91e5b5852ba15a9a11b2a165d6089acf83457fc477dc904d59cd71ed34c7a91762c6cc
checksum: 10c0/0c287867e5f6129d3def1edd9b63103a53c40d4dc8628839d4b6827e35eb8f0de5a4656f9d85f4457eba584f9871ebb2ad26c750b36bd75d9bbb8bcebdc4892c
languageName: node
linkType: hard

Expand Down
Loading

0 comments on commit 277f9c0

Please sign in to comment.