chore: nx migrate to v17.3 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsunderhus
force-pushed
the
build/chore--nx-migrate-17.3
branch
2 times, most recently
from
0464718
to
93fdc7b
Compare
bsunderhus
force-pushed
the
build/chore--nx-migrate-17.3
branch
2 times, most recently
from
1bd0f56
to
db75e58
Compare
bsunderhus
force-pushed
the
build/chore--nx-migrate-17.3
branch
from
db75e58
to
6e79d9e
Compare
bsunderhus
requested review from
spmonahan,
marcosmoura and
a team
as code owners
bsunderhus
force-pushed
the
build/chore--nx-migrate-17.3
branch
3 times, most recently
from
981efa0
to
ca5ef1f
Compare
spmonahan
reviewed
Jan 30, 2024
bsunderhus
force-pushed
the
build/chore--nx-migrate-17.3
branch
4 times, most recently
from
79949ce
to
3c921b7
Compare
ling1726
reviewed
Jan 31, 2024
bsunderhus
force-pushed
the
build/chore--nx-migrate-17.3
branch
4 times, most recently
from
10eda58
to
29d3565
Compare
bsunderhus
force-pushed
the
build/chore--nx-migrate-17.3
branch
2 times, most recently
from
fc797ea
to
98da716
Compare
Hotell
reviewed
Jan 31, 2024
...fluentui-contrib-react-data-grid-react-window-grid-25562c5b-7f46-4097-8b83-8b50cfbdf43a.json
Outdated
Show resolved
Hide resolved
Hotell
reviewed
Jan 31, 2024
packages/nx-plugin/src/generators/configure-storybook/files/.babelrc.template
Show resolved
Hide resolved
Hotell
reviewed
Jan 31, 2024
Hotell
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Thanks for this huge migration !
Pro tip for next time:
- migrating to new major including multiple releases is not the best pattern
- a more robust scenario is to upgrade to latest current major, once merged, migrating to new major with latest patch, following by migration of latest major
we dont have enabled resolve comments needed in order to merge, so I'm forced to press the red button manually until resolved 🥹
bsunderhus
force-pushed
the
build/chore--nx-migrate-17.3
branch
from
98da716
to
46403ef
Compare
Hotell
approved these changes
Jan 31, 2024
spmonahan
reviewed
Jan 31, 2024
bsunderhus
force-pushed
the
build/chore--nx-migrate-17.3
branch
from
46403ef
to
9cff565
Compare
ling1726
approved these changes
Feb 1, 2024
bsunderhus
force-pushed
the
build/chore--nx-migrate-17.3
branch
from
9cff565
to
467b0d8
Compare
marcosmoura
approved these changes
Feb 1, 2024
spmonahan
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of running
nx migrate latest(docs) at root of the project.@storybook/source-loader.nxto.gitignoreinterfaceovertype(@typescript-eslint/consistent-type-definitions).babelrcto every library and also include it on storybookgenerator(storybook build is breaking without a.babelrcfile on the root of libraryverdacciowhich seems to be a new dependency forpublishablelibs for@nx/js:lib(release blog post)