feat: implement docsite for contrib packages #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrokirpa
added
enhancement
dmytrokirpa
commented
Oct 11, 2024
dmytrokirpa
commented
Oct 11, 2024
| @@ -0,0 +1,159 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
This component was copied over from https://github.com/microsoft/fluentui/blob/master/apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx and will be removed once original component will be published as a part of a new package.
dmytrokirpa
commented
Oct 11, 2024
.storybook/components/Toc.tsx
Outdated
| @@ -0,0 +1,142 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
This component was copied over from https://github.com/microsoft/fluentui/blob/master/apps/public-docsite-v9/src/DocsComponents/Toc.stories.tsx and will be removed once original component will be published as a part of a new package.
dmytrokirpa
commented
Oct 11, 2024
dmytrokirpa
commented
Oct 11, 2024
dmytrokirpa
commented
Oct 11, 2024
dmytrokirpa
commented
Oct 11, 2024
dmytrokirpa
commented
Oct 11, 2024
dmytrokirpa
requested review from
a team,
mainframev,
spmonahan and
marcosmoura
as code owners
Jacqueline-ms
approved these changes
Oct 11, 2024
mainframev
requested changes
Oct 11, 2024
mainframev
reviewed
Oct 11, 2024
mainframev
approved these changes
Oct 12, 2024
Hotell
reviewed
Oct 15, 2024
packages/nx-plugin/src/generators/configure-storybook/files/.storybook/main.ts.template
Outdated
Show resolved
Hide resolved
packages/nx-plugin/src/generators/configure-storybook/files/.storybook/preview.tsx.template
Outdated
Show resolved
Hide resolved
Hotell
reviewed
Oct 16, 2024
layershifter
approved these changes
Oct 21, 2024
|
admin merging
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enhance the visibility of contrib packages, we've decided to create a documentation site that aggregates documentation for all packages in this repository, similar to what we do for the Fluent UI core repository. This will be integrated into
public-docsite-v9using the Storybook composition feature.What's New:
docsiteapplication powered bystorybook.DocsPagecomponents from the core to ensure a consistent user experience withpublic-docsite-v9, will be replaced with imports from a new package once it's available (planned for Q3, cc @Hotell)./.storybook.Demo:
Screen.Recording.2024-10-11.at.16.29.54.mov
Related Issues:
Partially addresses issue #175.