Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: default scrolling behavior does not work when the gridProps property of the DataGridBody component has an onScroll function #197

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

t-yonghu
Copy link

No description provided.

…erty of the DataGridBody component has an onScroll function
@t-yonghu t-yonghu requested a review from a team as a code owner July 11, 2024 11:43
@t-yonghu
Copy link
Author

I need to customize the onScroll function through gridprops, but customizing onScroll will cause inconsistent scrolling of the header and body of the table. After reading the component source code, I found that customizing onScroll will override the default onScroll function

@t-yonghu
Copy link
Author

If you have any questions, please contact me alias: t-yonghu

…erty of the DataGridBody component has an onScroll function
@stkevintan
Copy link

how about we make the default onScroll function as a parameter of the gridprops's onScroll ?. So developer can decide whether composing or replacing the default onScroll behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants