chore: update eslint to disallow globals #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be properly fixed in a separate change.
Hotell
reviewed
May 29, 2024
Hotell
reviewed
May 29, 2024
Hotell
reviewed
May 29, 2024
ling1726
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing global objects can cause problems in multi-window applications because we may be accessing a global object in the wrong
windowcontext.This change enables the
eslintno-restricted-globalsrule to disallow global access.For more details see the corresponding PR in Fluent UI: microsoft/fluentui#30967
This change does not address problems in
houdini-utilsspecifically as those will be addressed separately.