Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waste Reduction Logic App #690

Open
wants to merge 6 commits into
base: features/alerts
Choose a base branch
from
Open

Conversation

ro100e
Copy link

@ro100e ro100e commented Apr 17, 2024

πŸ› οΈ Description

Adding automation with the Waste Reduction Logic App is an automated detection mechanism provided by Azure Logic App The logic app will run on a configurable schedule to monitor selected subscriptions for a set of idle resources and send notifications once it finds any of those resources to alert admins to investigate and take action.

Added a new folder named logicapp within the docs folder and this is where the logic app deployment instructions are.
Added a new subfolder for media (.png files).
Added a new folder (waste reduction logic app) within the src folder.
Added to .json files for the logic app template code.

πŸ“· Screenshots

Included in the deployment instructions located in the media folder

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • πŸ‘ Manually deployed + verified

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • [] 🚨 This is a breaking change.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Yes (required for dev PRs)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)

Copy link
Contributor

@flanakin flanakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need a few PRs for this before it's ready for release. I created a new features/alerts branch. Can you resubmit this PR to that branch?

Once it's in a separate feature branch, my comments can be addressed in follow-up PRs. We just want to make sure that the only thing that goes into dev is complete, finalized changes including docs and changelog.

src/templates/waste reduction logic app/wasteApp.json Outdated Show resolved Hide resolved
src/templates/waste reduction logic app/wasteApp-Gov.json Outdated Show resolved Hide resolved
src/templates/waste reduction logic app/wasteApp.json Outdated Show resolved Hide resolved
src/templates/waste reduction logic app/wasteApp.json Outdated Show resolved Hide resolved
docs/_automation/logicApp/waste-reduction-logic-app.md Outdated Show resolved Hide resolved
docs/_automation/logicApp/waste-reduction-logic-app.md Outdated Show resolved Hide resolved
docs/_automation/logicApp/waste-reduction-logic-app.md Outdated Show resolved Hide resolved
docs/_automation/logicApp/waste-reduction-logic-app.md Outdated Show resolved Hide resolved
docs/_automation/logicApp/waste-reduction-logic-app.md Outdated Show resolved Hide resolved
docs/_automation/logicApp/waste-reduction-logic-app.md Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention πŸ‘‹ Issue or PR needs to be reviewed by the author or it will be closed due to no activity label Apr 21, 2024
@ro100e ro100e changed the base branch from dev to features/alerts April 24, 2024 15:47
Copy link
Author

@ro100e ro100e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items that have been resolved

  • JSON-> Bicep
  • Folder path (src/logic-apps)

docs/_automation/logicApp/waste-reduction-logic-app.md Outdated Show resolved Hide resolved
@ro100e ro100e closed this May 17, 2024
@ro100e ro100e reopened this May 17, 2024
@flanakin flanakin added this to the June 2024 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Attention πŸ‘‹ Issue or PR needs to be reviewed by the author or it will be closed due to no activity Needs: Review πŸ‘€ PR that is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants