[feat]: add lifecycle callbacks for hydration and template events #7199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
approved these changes
Oct 10, 2025
marchbox
reviewed
Oct 10, 2025
|
|
||
| **Template Registration Callbacks:** | ||
| - `elementDidRegister(name: string)` - Called after the JavaScript class definition has been registered as a partial definition | ||
| - `templateWillUpdate(name: string)` - Called before the template has been evaluated and assigned to the definition |
There was a problem hiding this comment.
Should we use something like “define”, “attach”, or “assign”, instead of “update”? Because I think “update” is generally associated with repeatable lifecycles like when an attribute changes the template will re-render.
| **Hydration Callbacks:** | ||
| - `elementWillHydrate(name: string)` - Called before an element begins hydration | ||
| - `elementDidHydrate(name: string)` - Called after an element completes hydration | ||
| - `hydrationComplete()` - Called once after all elements have completed hydration |
There was a problem hiding this comment.
Should we call this something like allElemenentsDidHydrate()?
|
|
||
| ### Callback Execution Order | ||
|
|
||
| The callbacks execute in the following sequence for each element: |
There was a problem hiding this comment.
Very much optional, but I’ve found the diagram on this page very helpful for illustrating the order of operations when I was using StencilJS: https://stenciljs.com/docs/component-lifecycle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds lifecycle hooks to the FASTDefinition, ElementController, and TemplateElement for hydration.
🎫 Issues
completes #7171
📑 Test Plan
The
lifecycle-callbacksfixture in fast-html provides Playwright tests for this feature.✅ Checklist
General
$ npm run change