Skip to content

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Sep 23, 2025

Pull Request

📖 Description

Currently Object.assign must be used when setting objects which have already been defined, this is un-ergonomic as it presupposes knowledge from a developer that a proxy is being used on this object. To circumvent that we now check in the _Changed function whether a proxy is assigned to the object, if not we can assume the user is setting the object and re-proxy the object.

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@janechu janechu merged commit a5ccfa8 into main Sep 23, 2025
14 of 17 checks passed
@janechu janechu deleted the users/janechu/more-elegant-solution-when-defining-objects branch September 23, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant