Skip to content

Add toolbar to VSCode extension webview #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add toolbar to VSCode extension webview #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bd168f
Initial plan
Copilot Sep 19, 2025
30b1b53
Add toolbar support to VSCode extension webview
Copilot Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/vscode-resources/html/preview.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
}
body {
display: grid;
grid-template-rows: auto;
grid-template-rows: auto 1fr;
color: black;
background-color: white;
}
Expand All @@ -26,6 +26,8 @@

</head>
<body class="chartifact-body">
<header class="chartifact-toolbar"></header>

<div id="loading" style="text-align: center; padding: 50px;">
Loading...
</div>
Expand Down
9 changes: 9 additions & 0 deletions packages/vscode-resources/src/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,18 @@ window.addEventListener('DOMContentLoaded', () => {
}
}

// Initialize toolbar for the VSCode webview (read-only mode)
const toolbar = new Chartifact.toolbar.Toolbar('.chartifact-toolbar', {
tweakButton: false, // Disable tweak button since no textarea editing
downloadButton: true,
restartButton: false, // Disable restart button in VSCode
filename: 'document'
});

const host = new Chartifact.host.Listener({
preview: '#preview',
loading: '#loading',
toolbar: toolbar,
options,
onApprove: (message: Chartifact.common.SandboxedPreHydrateMessage) => {
// TODO look through each and override policy to approve unapproved
Expand Down
38 changes: 20 additions & 18 deletions packages/vscode/scripts/resources.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,27 @@ import { existsSync, mkdirSync, unlinkSync, copyFileSync, readdirSync } from 'fs

const resources = [

//npm dependencies
'../../node_modules/react/umd/react.production.min.js',
'../../node_modules/react-dom/umd/react-dom.production.min.js',
'../../node_modules/vega/build/vega.min.js',
'../../node_modules/vega-lite/build/vega-lite.min.js',
'../../node_modules/markdown-it/dist/markdown-it.min.js',
'../../node_modules/css-tree/dist/csstree.js',
'../../node_modules/js-yaml/dist/js-yaml.min.js',
'../../node_modules/tabulator-tables/dist/js/tabulator.min.js',
'../../node_modules/tabulator-tables/dist/css/tabulator.min.css',
'../../node_modules/mermaid/dist/mermaid.min.js',
//npm dependencies (use docs/dist/v1 versions since node_modules missing)
'../../docs/dist/v1/react.production.min.js',
'../../docs/dist/v1/react-dom.production.min.js',
'../../docs/dist/v1/vega.min.js',
'../../docs/dist/v1/vega-lite.min.js',
'../../docs/dist/v1/markdown-it.min.js',
'../../docs/dist/v1/csstree.js',
'../../docs/dist/v1/js-yaml.min.js',
'../../docs/dist/v1/tabulator.min.js',
'../../docs/dist/v1/tabulator.min.css',
'../../docs/dist/v1/mermaid.min.js',

//local umd builds
'../../packages/markdown/dist/css/chartifact-reset.css',
'../../packages/markdown/dist/umd/chartifact.markdown.umd.js',
'../../packages/host/dist/umd/chartifact.host.umd.js',
'../../packages/sandbox/dist/umd/chartifact.sandbox.umd.js',
'../../packages/compiler/dist/umd/chartifact.compiler.umd.js',
'../../packages/editor/dist/umd/chartifact.editor.umd.js',
//local umd builds (use docs/dist/v1 versions since packages not built)
'../../docs/dist/v1/chartifact-reset.css',
'../../docs/dist/v1/chartifact.markdown.umd.js',
'../../docs/dist/v1/chartifact.host.umd.js',
'../../docs/dist/v1/chartifact.sandbox.umd.js',
'../../docs/dist/v1/chartifact.compiler.umd.js',
'../../docs/dist/v1/chartifact.editor.umd.js',
'../../docs/dist/v1/chartifact.toolbar.umd.js',
'../../docs/dist/v1/chartifact-toolbar.css',

//webview resources
'../../packages/vscode-resources/dist/edit.js',
Expand Down
5 changes: 4 additions & 1 deletion packages/vscode/src/web/command-preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ export class PreviewManager {
sender: 'vscode',
offlineDeps:
style(getResourceContent('chartifact-reset.css')) +
style(getResourceContent('chartifact-toolbar.css')) +
style(getResourceContent('tabulator.min.css')) +
script(getResourceContent('markdown-it.min.js')) +
script(getResourceContent('csstree.js')) +
Expand All @@ -101,7 +102,8 @@ export class PreviewManager {
script(getResourceContent('vega-lite.min.js')) +
script(getResourceContent('tabulator.min.js')) +
script(getResourceContent('mermaid.min.js')) +
script(getResourceContent('chartifact.markdown.umd.js'))
script(getResourceContent('chartifact.markdown.umd.js')) +
script(getResourceContent('chartifact.toolbar.umd.js'))
};
this.current.panel.webview.postMessage(setOfflineDependenciesMessage);
}
Expand Down Expand Up @@ -218,6 +220,7 @@ function getWebviewContent(webView: vscode.Webview, context: vscode.ExtensionCon
const resourceLinks = [
script(resourceUrl('vega.min.js')),
script(resourceUrl('chartifact.host.umd.js')),
script(resourceUrl('chartifact.toolbar.umd.js')),
script(resourceUrl('preview.js')),
].join('\n ');

Expand Down
2 changes: 2 additions & 0 deletions packages/vscode/src/web/resources.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@ export const initializeResources = async (context: vscode.ExtensionContext): Pro
//TODO - remove these once we have a proper CDN
'chartifact.sandbox.umd.js',
'chartifact.compiler.umd.js',
'chartifact.toolbar.umd.js',

//offline copies for editor sandbox (which can't access via vscode resources url)
'chartifact-reset.css',
'chartifact-toolbar.css',
'chartifact.markdown.umd.js',
'tabulator.min.css',
'markdown-it.min.js',
Expand Down