Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6741] Update generators templates and VSIX to .Net 8 #6762

Merged
merged 6 commits into from
May 16, 2024

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #6741

Description

This PR updates all generators from net6 to net8.

Specific Changes

  • Templates
    • Updates all related files where the net6 configuration appear, changing it to net8.
    • Default template installation to net8, but leave net6 and net8 as supported options. Since we maintained both in the SDK.
  • VSIX
    • Updates all related files to target net8.
    • Fixed an issue when generating the CoreBotWithTests sample failed because it was referencing nonexistent files.

Testing

The following images show all three bots working and the update reference in the VSIX samples.
imagen
imagen
imagen
imagen

@sw-joelmut sw-joelmut requested a review from a team as a code owner March 14, 2024 13:34
@sw-joelmut sw-joelmut added the Automation: No parity PR does not need to be applied to other languages. label Mar 14, 2024
@coveralls
Copy link
Collaborator

coveralls commented Mar 14, 2024

Pull Request Test Coverage Report for Build 389180

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 78.163%

Totals Coverage Status
Change from base Build 388884: 0.006%
Covered Lines: 26180
Relevant Lines: 33494

💛 - Coveralls

@JhontSouth
Copy link
Collaborator

Hi @tracyboehrer, the changes to maintain support for Net Core 3.1 are ready in the PR.

@tracyboehrer tracyboehrer merged commit b15a8bf into main May 16, 2024
8 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/net8-generators-templates-vsix branch May 16, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.Net 8
4 participants