Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues flagged by lint rules #1017

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fix issues flagged by lint rules #1017

merged 1 commit into from
Nov 25, 2024

Conversation

ecraig12345
Copy link
Member

In the beachball next (v3) branch, I enabled eslint. This PR brings back some of the fixes made in response to lint rules:

  • use optional catch bindings (remove (err) from catch (err) if not used)
  • replace non-null assertions with optional chaining or other checks
  • fix shadowed names
  • prefer const
  • ensure the correct types are used instead of implicit or explicit any
  • remove unused imports and parameters
  • use explicit module boundary types

(I didn't enable eslint in master/v2 because in next I'm using eslint v9 flat config, which is probably not compatible with Node 14, and I'm not sure it's worthwhile to back-port the config.)

@ecraig12345 ecraig12345 merged commit 29103cf into master Nov 25, 2024
5 checks passed
@ecraig12345 ecraig12345 deleted the ecraig/lint-cleanup branch November 25, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant