Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sriov-network-device-plugin: upgrade from 3.5.1 -> 3.6.2 #7463

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

sudmis
Copy link

@sudmis sudmis commented Jan 25, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • [x ] The toolchain has been rebuilt successfully (or no changes were made to it)
  • [x ] The toolchain/worker package manifests are up-to-date
  • [x ] Any updated packages successfully build (or no packages were changed)
  • [x ] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • [x ] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • [x ] All package sources are available
  • [x ] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • [x ] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • [x ] All source files have up-to-date hashes in the *.signatures.json files
  • [x ] sudo make go-tidy-all and sudo make go-test-coverage pass
  • [x ] Documentation has been updated to match any changes to the build system
  • [x ] Ready to merge

Summary

The upgraded from 3.5.1 to 3.6.2 is needed to make latest version of sriov-network-device-plugin available. This has also fixed CVEs related to older version.

The minor version jump is done in the PR as docker is not able to pull 3.6.0 and 3.6.1 version of the image.

Change Log
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2022-1996

Test Methodology

Container build: Pipelines - Run Publish-Golden-Containers (azure.com)
Container testing build: Pipelines - Run 20240206.1 (azure.com)

@sudmis sudmis requested a review from a team as a code owner January 25, 2024 16:42
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please retarget the branch to main instead of 2.0
Any development activity for AzureLinux 2.0 (aka CBL-Mariner) goes via main.

@mfrw mfrw changed the title Sriov upgrade3.6.2 Sriov upgrade from 3.5.1 -> 3.6.2 Jan 29, 2024
@mfrw mfrw changed the title Sriov upgrade from 3.5.1 -> 3.6.2 sriov-network-device-plugin: upgrade from 3.5.1 -> 3.6.2 Jan 29, 2024
@sudmis sudmis force-pushed the sriovUpgrade3.6.2 branch from e2cc08d to dc3dae0 Compare January 29, 2024 09:45
@sudmis sudmis requested review from a team as code owners January 29, 2024 09:45
@sudmis sudmis changed the base branch from 2.0 to main January 29, 2024 09:47
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Jan 29, 2024
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test build failed: PR-7463

@mfrw mfrw closed this Jan 29, 2024
@mfrw mfrw reopened this Jan 29, 2024
@mfrw
Copy link
Member

mfrw commented Jan 29, 2024

Closing & Re-Opening to re-trigger stuck Github Checks

cgmanifest.json Show resolved Hide resolved
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Test Build: PR-7463

Copy link
Contributor

@PawelWMS PawelWMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill out the PR's summary with a focus on explaining why we're doing the minor version jump for this package.

@mfrw mfrw merged commit 07bfaa1 into microsoft:main Feb 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants