Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert ZONE_DMA option to avoid memory ussage overuse #12221

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Revert ZONE_DMA option to avoid memory ussage overuse #12221

merged 2 commits into from
Feb 5, 2025

Conversation

Alberto-Perez-Guevara
Copy link
Contributor

@Alberto-Perez-Guevara Alberto-Perez-Guevara commented Feb 4, 2025 •
edited
Loading

Revert ZONE_DMA option to avoid memory ussage overuse

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

Revert ZONE_DMA option to avoid memory ussage overuse

Change Log

SPECS-SIGNED/fwctl-signed/fwctl-signed.spec
SPECS-SIGNED/iser-signed/iser-signed.spec
SPECS-SIGNED/isert-signed/isert-signed.spec
SPECS-SIGNED/kernel-64k-signed/kernel-64k-signed.spec
SPECS-SIGNED/kernel-signed/kernel-signed.spec
SPECS-SIGNED/kernel-uki-signed/kernel-uki-signed.spec
SPECS-SIGNED/knem-modules-signed/knem-modules-signed.spec
SPECS-SIGNED/mft_kernel-signed/mft_kernel-signed.spec
SPECS-SIGNED/mlnx-nfsrdma-signed/mlnx-nfsrdma-signed.spec
SPECS-SIGNED/mlnx-ofa_kernel-modules-signed/mlnx-ofa_kernel-modules-signed.spec
SPECS-SIGNED/srp-signed/srp-signed.spec
SPECS-SIGNED/xpmem-modules-signed/xpmem-modules-signed.spec
SPECS/fwctl/fwctl.spec
SPECS/iser/iser.spec
SPECS/isert/isert.spec
SPECS/kernel-64k/kernel-64k.spec
SPECS/kernel-headers/kernel-headers.spec
SPECS/kernel/config
SPECS/kernel/kernel-uki.spec
SPECS/kernel/kernel.signatures.json
SPECS/kernel/kernel.spec
SPECS/knem/knem.spec
SPECS/mft_kernel/mft_kernel.spec
SPECS/mlnx-nfsrdma/mlnx-nfsrdma.spec
SPECS/mlnx-ofa_kernel/mlnx-ofa_kernel.spec
SPECS/srp/srp.spec
SPECS/xpmem/xpmem.spec
toolkit/resources/manifests/package/pkggen_core_aarch64.txt
toolkit/resources/manifests/package/pkggen_core_x86_64.txt
toolkit/resources/manifests/package/toolchain_aarch64.txt
toolkit/resources/manifests/package/toolchain_x86_64.txt

Does this affect the toolchain?

NO

Test Methodology
  • Pipeline build id: 728001
  • Local build with changes
  • tested on VM Standard ND96isr MI300X v5
    Before

Plain Text
free -m
total used free shared buff/cache available
Mem: 1864667 10028 1858638 1 1578 1854639
Swap: 0 0 0

After
Plain Text
free -m
total used free shared buff/cache available
Mem: 1864667 8972 1860198 1 558 1855695
Swap: 0 0 0

@Alberto-Perez-Guevara
Revert ZONE_DMA option to avoid memory ussage overuse
7a76212 
 Changes to be committed:
	modified:   ../../SPECS-SIGNED/fwctl-signed/fwctl-signed.spec
	modified:   ../../SPECS-SIGNED/iser-signed/iser-signed.spec
	modified:   ../../SPECS-SIGNED/isert-signed/isert-signed.spec
	modified:   ../../SPECS-SIGNED/kernel-64k-signed/kernel-64k-signed.spec
	modified:   ../../SPECS-SIGNED/kernel-signed/kernel-signed.spec
	modified:   ../../SPECS-SIGNED/kernel-uki-signed/kernel-uki-signed.spec
	modified:   ../../SPECS-SIGNED/knem-modules-signed/knem-modules-signed.spec
	modified:   ../../SPECS-SIGNED/mft_kernel-signed/mft_kernel-signed.spec
	modified:   ../../SPECS-SIGNED/mlnx-nfsrdma-signed/mlnx-nfsrdma-signed.spec
	modified:   ../../SPECS-SIGNED/mlnx-ofa_kernel-modules-signed/mlnx-ofa_kernel-modules-signed.spec
	modified:   ../../SPECS-SIGNED/srp-signed/srp-signed.spec
	modified:   ../../SPECS-SIGNED/xpmem-modules-signed/xpmem-modules-signed.spec
	modified:   ../fwctl/fwctl.spec
	modified:   ../iser/iser.spec
	modified:   ../isert/isert.spec
	modified:   ../kernel-64k/kernel-64k.spec
	modified:   ../kernel-headers/kernel-headers.spec
	modified:   config
	modified:   kernel-uki.spec
	modified:   kernel.signatures.json
	modified:   kernel.spec
	modified:   ../knem/knem.spec
	modified:   ../mft_kernel/mft_kernel.spec
	modified:   ../mlnx-nfsrdma/mlnx-nfsrdma.spec
	modified:   ../mlnx-ofa_kernel/mlnx-ofa_kernel.spec
	modified:   ../srp/srp.spec
	modified:   ../xpmem/xpmem.spec
	modified:   ../../toolkit/resources/manifests/package/pkggen_core_aarch64.txt
	modified:   ../../toolkit/resources/manifests/package/pkggen_core_x86_64.txt
	modified:   ../../toolkit/resources/manifests/package/toolchain_aarch64.txt
	modified:   ../../toolkit/resources/manifests/package/toolchain_x86_64.txt
@Alberto-Perez-Guevara
Fix change log signature
98ef29a 
 Changes to be committed:
	modified:   SPECS-SIGNED/fwctl-signed/fwctl-signed.spec
	modified:   SPECS-SIGNED/iser-signed/iser-signed.spec
	modified:   SPECS-SIGNED/isert-signed/isert-signed.spec
	modified:   SPECS-SIGNED/kernel-64k-signed/kernel-64k-signed.spec
	modified:   SPECS-SIGNED/kernel-signed/kernel-signed.spec
	modified:   SPECS-SIGNED/kernel-uki-signed/kernel-uki-signed.spec
	modified:   SPECS-SIGNED/knem-modules-signed/knem-modules-signed.spec
	modified:   SPECS-SIGNED/mft_kernel-signed/mft_kernel-signed.spec
	modified:   SPECS-SIGNED/mlnx-nfsrdma-signed/mlnx-nfsrdma-signed.spec
	modified:   SPECS-SIGNED/mlnx-ofa_kernel-modules-signed/mlnx-ofa_kernel-modules-signed.spec
	modified:   SPECS-SIGNED/srp-signed/srp-signed.spec
	modified:   SPECS-SIGNED/xpmem-modules-signed/xpmem-modules-signed.spec
	modified:   SPECS/fwctl/fwctl.spec
	modified:   SPECS/iser/iser.spec
	modified:   SPECS/isert/isert.spec
	modified:   SPECS/kernel-64k/kernel-64k.spec
	modified:   SPECS/kernel-headers/kernel-headers.spec
	modified:   SPECS/kernel/kernel-uki.spec
	modified:   SPECS/kernel/kernel.spec
	modified:   SPECS/knem/knem.spec
	modified:   SPECS/mft_kernel/mft_kernel.spec
	modified:   SPECS/mlnx-nfsrdma/mlnx-nfsrdma.spec
	modified:   SPECS/mlnx-ofa_kernel/mlnx-ofa_kernel.spec
	modified:   SPECS/srp/srp.spec
	modified:   SPECS/xpmem/xpmem.spec
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Feb 4, 2025
@Alberto-Perez-Guevara Alberto-Perez-Guevara marked this pull request as ready for review February 5, 2025 00:25
@Alberto-Perez-Guevara Alberto-Perez-Guevara requested a review from a team as a code owner February 5, 2025 00:25
@Alberto-Perez-Guevara Alberto-Perez-Guevara merged commit 347d25e into 3.0-dev Feb 5, 2025
13 checks passed
@Alberto-Perez-Guevara Alberto-Perez-Guevara deleted the aperezguevar-zone-dma-revert branch February 5, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlmenge rlmenge rlmenge approved these changes

@jslobodzian jslobodzian jslobodzian approved these changes

Assignees
No one assigned
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alberto-Perez-Guevara @rlmenge @jslobodzian