-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vitess: Fix CVE-2024-45339 [HIGH] #12173
base: fasttrack/2.0
Are you sure you want to change the base?
vitess: Fix CVE-2024-45339 [HIGH] #12173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some nit
Co-authored-by: Riken Maharjan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vitess PTest and MySql ptest failed but they have been failing for a while. hence approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vitess ptest is failing. Did we investigate what's wrong there? The test output suggests a typo or some sort of minor issue in the command line:
time="2025-02-01T03:42:17Z" level=debug msg="====== CHECK START vitess"
time="2025-02-01T03:42:17Z" level=debug msg="go check: unknown command"
time="2025-02-01T03:42:17Z" level=debug msg="Run 'go help' for usage."
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology