Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade:wavpack to version 5.7.0 #11645

Open
wants to merge 3 commits into
base: 3.0-dev
Choose a base branch
from
Open

Upgrade:wavpack to version 5.7.0 #11645

wants to merge 3 commits into from

Conversation

AkarshHCL
Copy link

@AkarshHCL AkarshHCL commented Dec 22, 2024 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

What does the PR accomplish, why was it needed?

Change Log
  • SPECS-EXTENDED/wavpack/wavpack.signatures.json
  • SPECS-EXTENDED/wavpack/wavpack.spec
  • cgmanifest.json
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

@AkarshHCL AkarshHCL requested review from a team as code owners December 22, 2024 20:06
mfrw
mfrw reviewed Jan 20, 2025
View reviewed changes
SPECS-EXTENDED/wavpack/wavpack.spec Outdated
Version: 5.7.0
Release: 4%{?dist}
License: BSD-3-Clause AND BSD-2-Clause AND LicenseRef-Fedora-Public-Domain
Url: http://www.wavpack.com/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should prefer https

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added requested changes. Requesting for review.

mfrw
mfrw reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we please rebase with latest 3.0-dev

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Jan 21, 2025
@AkarshHCL AkarshHCL requested a review from mfrw February 4, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrw mfrw Awaiting requested review from mfrw

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AkarshHCL @mfrw