fix(docker): improve retrieval of layer id during inspect #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
YodaDaCoda
changed the title
|
or you could just split line-by-line, i'm sure that won't fail in new and exciting ways 😒 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix microsoft/azure-pipelines-tasks#20506
Accounts for the change from #373 where layerId may or may not include an algorithm.
It appears that when a Dockerfile has a multiline RUN command,
docker historyoutputs thecreatedByproperty as-is, with newlines. This breaks retrieval of the layerId from the history, as the existing code splits the history by newline and attempts to find the layerId in the first line.This change uses regex to find the first layerId mentioned in the history, regardless of newlines.