Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

[Workbook Added] Solutions provided for Task 1.1 and 1.2 #674

Merged
merged 5 commits into from
Nov 16, 2021

Conversation

devikamehra
Copy link
Contributor

As per the Issue #542, I have started with Key_Distribution_BB84 Workbook. So far I have covered Task 1.1 and Task 1.2 only with an intention to check if I am going in the right direction. There are few hyperlinks added in the Key_Distribution_BB84 quantum kata as well to ensure the Workbook works smoothly.

Copy link
Contributor

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start! I left some comments, once you address them we can merge this PR and you can work on the later tasks in the next one.
(Apologies for the delay reviewing, I spent the last week at a conference so only catching up now)

Thank you!

KeyDistribution_BB84/KeyDistribution_BB84.ipynb Outdated Show resolved Hide resolved
KeyDistribution_BB84/KeyDistribution_BB84.ipynb Outdated Show resolved Hide resolved
KeyDistribution_BB84/Workbook_KeyDistribution_BB84.ipynb Outdated Show resolved Hide resolved
KeyDistribution_BB84/Workbook_KeyDistribution_BB84.ipynb Outdated Show resolved Hide resolved
KeyDistribution_BB84/Workbook_KeyDistribution_BB84.ipynb Outdated Show resolved Hide resolved
KeyDistribution_BB84/Workbook_KeyDistribution_BB84.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I did a couple of small edits to polish it a bit, didn't make sense to send the PR back for the small things.

I'll merge this PR once the CI build passes, and then you can open a separate one if you want to keep working on this workbook.
Thank you!

@tcNickolas tcNickolas merged commit d3718a3 into microsoft:main Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants