Update runner.md to catch runner structure change. #37515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
doc/devdocs/runner.md
Outdated
Comment on lines
42
to
43
| Contains codes for restart a process. | ||
|
|
There was a problem hiding this comment.
The phrase 'Contains codes for restart a process' is grammatically incorrect. It should be 'Contains code for restarting a process.'
Suggested change
| Contains codes for restart a process. | |
| Contains code for restarting a process. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
doc/devdocs/runner.md
Outdated
| Contains logic that periodically triggers module-specific setting's telemetry delivery and manages timing and error handling for the process. | ||
|
|
||
| #### [`UpdateUtils.cpp`](/src/runner/UpdateUtils.cpp) | ||
| Contains code to handle the automatic update checking, notification, and installation process for PowerToys, including functions for periodic update checks, manual update checks, and displaying notifications to the user about new versions. |
There was a problem hiding this comment.
[nitpick] The sentence is too wordy and could be clearer. Consider breaking it down into simpler sentences for better readability.
Suggested change
| Contains code to handle the automatic update checking, notification, and installation process for PowerToys, including functions for periodic update checks, manual update checks, and displaying notifications to the user about new versions. | |
| Contains code to handle the automatic update checking, notification, and installation process for PowerToys. It includes functions for periodic update checks and manual update checks. It also displays notifications to the user about new versions. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
This comment has been minimized.
This comment has been minimized.
vanzue
force-pushed
the
user/vanzue/update-runner-doc
branch
from
30bba33 to
798e099
Compare
|
@microsoft-github-policy-service agree [company="{microsoft}"] |
Sparkiwan
approved these changes
Feb 18, 2025
vanzue
requested review from
a team and
jaimecbernardo
and removed request for
jaimecbernardo and
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update runner documentation to reflect newest code structure
PR Checklist
Detailed Description of the Pull Request / Additional comments
runner.md file is out of date, update them to reflect newest code structure
The runner documentation is out of date, powertoys_events.cpp,lowlevel_keyboard_event.cpp, win_hook_event.cpp
does not exist any more, and make simple document for newly added files for their functionality.