Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extra space from welcome page #35778

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

agarwalishita
Copy link
Contributor

@agarwalishita agarwalishita commented Nov 5, 2024

Issue : #35753

Description : Extra space found in the welcome page text "You can change this at any time from settings"

Fix: Removed extra space

@htcfreek
Copy link
Collaborator

@agarwalishita
Please link the issue in the description.

@htcfreek
Copy link
Collaborator

I suggest to add a small space/margin between the info bar and the page content (release notes). Currently it looks a bit squashed.

@agarwalishita
Copy link
Contributor Author

I suggest to add a small space/margin between the info bar and the page content (release notes). Currently it looks a bit squashed.

sure, I will add that, but currently a test case is failing

@htcfreek
Copy link
Collaborator

but currently a test case is failing

@agarwalishita
I think you can ignore this. It's only a flakiness of our CI. I think the next commit will pass CI.

@agarwalishita
Copy link
Contributor Author

but currently a test case is failing

@agarwalishita I think you can ignore this. It's only a flakiness of our CI. I think the next commit will pass CI.

Sure, will push the next change then

@agarwalishita
Copy link
Contributor Author

@htcfreek hey, can you please review and approve?

@crutkas crutkas merged commit 7c98765 into microsoft:main Nov 26, 2024
11 checks passed
@crutkas
Copy link
Member

crutkas commented Nov 26, 2024

@agarwalishita thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants