Skip to content

Commit

Permalink
[FileExplorer]Add warnings for incompatibilities (#17273)
Browse files Browse the repository at this point in the history
  • Loading branch information
jaimecbernardo authored Mar 25, 2022
1 parent 79227b9 commit bdbf0b8
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/settings-ui/Settings.UI/Strings/en-us/Resources.resw
Original file line number Diff line number Diff line change
Expand Up @@ -1017,6 +1017,14 @@ Made with 💗 by Microsoft and the PowerToys community.</value>
<data name="FileExplorerPreview_RebootRequired.Title" xml:space="preserve">
<value>A reboot may be required for changes to these settings to take effect</value>
</data>
<data name="FileExplorerPreview_PreviewHandlerOutlookIncompatibility.Title" xml:space="preserve">
<value>Enabling the preview handlers will override other preview handlers already installed - there have been reports of incompatibility between Outlook and the PDF Preview Handler</value>
<comment>Outlook is the name of a Microsoft product</comment>
</data>
<data name="FileExplorerPreview_ThumbnailsMightNotAppearOnRemoteFolders.Title" xml:space="preserve">
<value>Thumbnails might not appear on paths managed by cloud storage solutions like OneDrive, since these solutions may get their thumbnails from the cloud instead of generating them locally</value>
<comment>OneDrive is the name of a Microsoft product</comment>
</data>
<data name="FancyZones_ExcludeApps_TextBoxControl.PlaceholderText" xml:space="preserve">
<value>Example: outlook.exe</value>
<comment>Don't translate outlook.exe</comment>
Expand Down
12 changes: 12 additions & 0 deletions src/settings-ui/Settings.UI/Views/PowerPreviewPage.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@
<StackPanel Orientation="Vertical">

<controls:SettingsGroup x:Uid="FileExplorerPreview_PreviewPane">
<muxc:InfoBar Severity="Warning"
x:Uid="FileExplorerPreview_PreviewHandlerOutlookIncompatibility"
IsOpen="True"
IsTabStop="True"
IsClosable="False"
/>
<controls:Setting x:Uid="FileExplorerPreview_ToggleSwitch_Preview_SVG" Icon="&#xE91B;">
<controls:Setting.ActionContent>
<ToggleSwitch IsOn="{x:Bind Mode=TwoWay, Path=ViewModel.SVGRenderIsEnabled}"
Expand Down Expand Up @@ -77,6 +83,12 @@
IsTabStop="True"
IsClosable="False"
/>
<muxc:InfoBar Severity="Warning"
x:Uid="FileExplorerPreview_ThumbnailsMightNotAppearOnRemoteFolders"
IsOpen="True"
IsTabStop="True"
IsClosable="False"
/>
<controls:Setting x:Uid="FileExplorerPreview_ToggleSwitch_SVG_Thumbnail" Icon="&#xE91B;">
<controls:Setting.ActionContent>
<ToggleSwitch IsOn="{x:Bind Mode=TwoWay, Path=ViewModel.SVGThumbnailIsEnabled}"
Expand Down

0 comments on commit bdbf0b8

Please sign in to comment.