Skip to content

Commit

Permalink
Merge pull request #33 from Microsoft/develop
Browse files Browse the repository at this point in the history
Dev to master with summarization ability
  • Loading branch information
psmacmur authored Mar 7, 2019
2 parents 668fe7f + bfbb845 commit f9328c4
Show file tree
Hide file tree
Showing 13 changed files with 2,943 additions and 4,094 deletions.
6 changes: 3 additions & 3 deletions capabilities.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
"name": "summary",
"displayName": "Preview",
"description": "Preview text; only displayed on cards",
"kind": 0
"kind": 1
},
{
"name": "content",
"displayName": "Content",
"description": "Full content to display in the reader",
"kind": 0
"kind": 1
},
{
"name": "imageUrl",
Expand All @@ -46,7 +46,7 @@
"name": "metadata",
"displayName": "MetaData Fields",
"description": "Key-value pairs for the table on the back of the cards",
"kind": 0
"kind": 1
},
{
"name": "topBarColor",
Expand Down
4 changes: 0 additions & 4 deletions lib/@uncharted/cards/example/font-awesome.min.css

This file was deleted.

Binary file removed lib/@uncharted/cards/example/fonts/FontAwesome.otf
Binary file not shown.
Binary file not shown.
2,671 changes: 0 additions & 2,671 deletions lib/@uncharted/cards/example/fonts/fontawesome-webfont.svg

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.
2 changes: 1 addition & 1 deletion lib/@uncharted/cards/example/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html>
<head>
<title>Cards</title>
<link rel="stylesheet" href="font-awesome.min.css">
<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.4.1/css/all.css" integrity="sha384-5sAR7xN1Nv6T6+dT2mhtzEpVJvfS3NScPQTrOxhwjIuvcA67KV2R5Jz6kr4abQsz" crossorigin="anonymous">
<link rel="stylesheet" href="style.css">
<script src="http://code.jquery.com/jquery-3.2.1.js"></script>
</head>
Expand Down
14 changes: 7 additions & 7 deletions lib/@uncharted/cards/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@uncharted/cards",
"version": "0.13.6",
"version": "0.13.7",
"main": "dist/uncharted.cards.js",
"scripts": {
"test": "./node_modules/.bin/karma start",
Expand All @@ -27,12 +27,11 @@
"clean-webpack-plugin": "^0.1.16",
"cross-env": "^5.0.5",
"css-loader": "^0.28.4",
"eslint": "^4.6.1",
"eslint-loader": "^1.9.0",
"extract-text-webpack-plugin": "^3.0.0",
"eslint": "^5.15.1",
"eslint-loader": "^2.1.2",
"handlebars": "^4.0.10",
"handlebars-loader": "^1.7.0",
"karma": "^2.0.0",
"karma": "^4.0.1",
"karma-chrome-launcher": "^2.2.0",
"karma-mocha": "^1.3.0",
"karma-mocha-reporter": "^2.2.5",
Expand All @@ -47,7 +46,8 @@
"sinon": "^4.4.6",
"sinon-chai": "^3.0.0",
"style-loader": "^0.18.2",
"webpack": "^3.11.0",
"webpack-dev-server": "^2.11.1"
"webpack": "^4.29.6",
"webpack-cli": "^3.2.3",
"webpack-dev-server": "^3.2.1"
}
}
26 changes: 17 additions & 9 deletions lib/@uncharted/cards/webpack.config.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
const path = require('path');
const webpack = require('webpack');
const CleanWebpackPlugin = require('clean-webpack-plugin');
const ExtractTextPlugin = require('extract-text-webpack-plugin');

const OUTPUT_FILE_NAME = 'uncharted.cards';

Expand Down Expand Up @@ -36,18 +35,24 @@ const config = {
loader: 'babel-loader',
options: {
presets: [
[ 'latest', { es2015: { modules: false } } ],
['latest', { es2015: { modules: false } }],
],
},
exclude: /node_modules/,
},
{
test: /\.scss$/,
use: isServing
? ['style-loader', 'css-loader', 'sass-loader']
: ExtractTextPlugin.extract({
use: ['css-loader', 'sass-loader'],
}),
test: /\.scss$|\.css$/,
use: [
{
loader: "style-loader" // creates style nodes from JS strings
},
{
loader: "css-loader" // translates CSS into CommonJS
},
{
loader: "sass-loader" // compiles Sass to CSS
}
]
},
{
test: /\.handlebars$/,
Expand Down Expand Up @@ -78,7 +83,6 @@ const config = {
if (!isServing) {
config.plugins.push(...[
new CleanWebpackPlugin(['dist']),
new ExtractTextPlugin(`${outputFileName}.css`),
]);
}

Expand All @@ -92,6 +96,8 @@ if (isProduction) {
},
}),
]);

config.mode = 'production';
} else {
config.output.libraryTarget = 'window';
config.output.library = ['Uncharted', 'Cards'];
Expand All @@ -103,6 +109,8 @@ if (isProduction) {
},
}),
]);

config.mode = 'development';
}

module.exports = config;
21 changes: 11 additions & 10 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "powerbi-visuals-cardbrowser",
"version": "1.1.3",
"version": "1.1.4",
"description": "Card Browser, a custom visual for PowerBI",
"main": "src/index.js",
"scripts": {
Expand All @@ -26,28 +26,27 @@
"url": "https://github.com/Microsoft/PowerBI-visuals-CardBrowser"
},
"privateSubmodules": {
"@uncharted/cards": "0.13.6"
"@uncharted/cards": "0.13.7"
},
"devDependencies": {
"@types/jest": "^22.2.3",
"@types/jquery": "^3.3.0",
"@types/lodash-es": "^4.17.0",
"@types/moment": "^2.13.0",
"@types/node": "^9.4.1",
"babel-core": "^6.26.0",
"babel-loader": "^7.1.2",
"babel-polyfill": "^6.26.0",
"babel-preset-env": "^1.6.1",
"chai": "^4.1.2",
"chokidar": "^2.0.0",
"chokidar": "^2.1.2",
"clean-css": "^4.1.9",
"connect": "^3.6.5",
"eslint": "^4.17.0",
"eslint-loader": "^1.9.0",
"eslint": "^5.15.1",
"eslint-loader": "^2.1.2",
"fs-extra": "^7.0.0",
"handlebars": "^4.0.11",
"handlebars-loader": "^1.6.0",
"jest": "^22.4.3",
"jest": "^24.3.0",
"jquery": "^3.3.1",
"json": "^9.0.6",
"memory-fs": "^0.4.1",
Expand All @@ -59,15 +58,16 @@
"onchange": "^3.3.0",
"powerbi-visuals": "^0.6.0",
"serve-static": "^1.13.2",
"sinon": "^4.2.2",
"sinon-chai": "^2.14.0",
"sinon": "^7.2.7",
"sinon-chai": "^3.3.0",
"targz": "^1.0.1",
"ts-jest": "^22.4.2",
"ts-loader": "^3.5.0",
"tslint": "^5.9.1",
"tslint-loader": "^3.5.3",
"tslint-microsoft-contrib": "^5.0.3",
"typescript": "^2.7.2",
"upath": "^1.1.1",
"webpack": "^3.11.0"
},
"dependencies": {
Expand All @@ -93,6 +93,7 @@
"js",
"jsx",
"json"
]
],
"testURL": "http://localhost/"
}
}
Loading

0 comments on commit f9328c4

Please sign in to comment.