Allow multiple relationships in ConnectorType #2747

LucGenetier · 2024-11-20T10:58:05Z

Allow multiple relationships in ConnectorType
Fix CompileTimeTypeWrapperRecordValue.TryGetField
Add Equals to ConnectorType

This update doesn't update CdpRecordType yet
DV and NL repos are not impacted by these changes

Fix CompileTimeTypeWrapperRecordValue.TryGetField

LucGenetier · 2024-11-20T11:26:00Z

✅ No public API change.

src/libraries/Microsoft.PowerFx.Connectors/Public/ConnectorType.cs

src/libraries/Microsoft.PowerFx.Connectors/Tabular/Capabilities/ComplexColumnCapabilities.cs

src/libraries/Microsoft.PowerFx.Core/Public/Values/CompileTimeTypeWrapperRecordValue.cs

src/libraries/Microsoft.PowerFx.Connectors/OpenApiExtensions.cs

src/libraries/Microsoft.PowerFx.Connectors/Public/ConnectorType.cs

src/libraries/Microsoft.PowerFx.Connectors/Tabular/Capabilities/ColumnCapabilitiesDefinition.cs

LucGenetier · 2024-11-21T11:33:22Z

Public API changes:
❌CP0002 M:Microsoft.PowerFx.Connectors.CdpExtensions.TryGetFieldExternalTableName(Microsoft.PowerFx.Types.RecordType,System.String,System.String@,System.String@)

MikeStall · 2024-11-21T22:04:54Z

src/libraries/Microsoft.PowerFx.Connectors/OpenApiExtensions.cs

@@ -17,6 +17,8 @@
 using Microsoft.PowerFx.Core.Utils;
 using Microsoft.PowerFx.Types;
 using static Microsoft.PowerFx.Connectors.Constants;
+
+#pragma warning disable SA1000 // The keyword 'new' should be followeed by a space


Do we just want to remove this at the editorconfig level?

MikeStall · 2024-11-21T22:48:30Z

src/libraries/Microsoft.PowerFx.Connectors/Public/ConnectorRelationship.cs

+
+namespace Microsoft.PowerFx.Connectors
+{
+    public class ConnectorRelationship


ConnectorRelationship

Is this CDP specific?

If so, how do non-CDP shims (ServiceNow) leverage it?

for now, yes
as discussed this is a temporary thing
I'll add [Obsolete] to it

MikeStall · 2024-11-21T23:25:41Z

src/libraries/Microsoft.PowerFx.Connectors/Public/ConnectorType.cs

+                   this.DisplayName == other.DisplayName &&
+                   this.Description == other.Description &&
+                   this.IsRequired == other.IsRequired &&
+                   Enumerable.SequenceEqual((IList<ConnectorType>)this.Fields ?? Array.Empty<ConnectorType>(), (IList<ConnectorType>)other.Fields ?? Array.Empty<ConnectorType>()) &&


(IList)this.Fields

This is recursive - how do we verify this is not a stack overflow?

LucGenetier · 2024-11-21T23:26:17Z

src/libraries/Microsoft.PowerFx.Connectors/Public/CdpExtensions.cs

 using Microsoft.PowerFx.Types;

 namespace Microsoft.PowerFx.Connectors
 {
    public static class CdpExtensions
    {
-        public static bool TryGetFieldExternalTableName(this RecordType recordType, string fieldName, out string tableName, out string foreignKey)
+        public static bool TryGetFieldRelationships(this RecordType recordType, string fieldName, out IEnumerable<ConnectorRelationship> relationships)


TryGetFieldRelationships

I'll add [Obsolete]

MikeStall · 2024-11-21T23:36:18Z

src/libraries/Microsoft.PowerFx.Connectors/Tabular/Capabilities/ColumnCapabilities.cs

@@ -72,5 +73,32 @@ public static ColumnCapabilities ParseColumnCapabilities(IDictionary<string, IOp
                IsChoice = isChoice
            });
        }
+
+        public bool Equals(ColumnCapabilities other)


public bool Equals(ColumnCapabilities other)

Intrinsically, why would we ever need to compare ColumnCapabilities?

Allow multiple relationships in ConnectorType

9fae8de

Fix CompileTimeTypeWrapperRecordValue.TryGetField

LucGenetier requested a review from a team as a code owner November 20, 2024 10:58

LucGenetier commented Nov 20, 2024

View reviewed changes

src/libraries/Microsoft.PowerFx.Connectors/Public/ConnectorType.cs Show resolved Hide resolved

LucGenetier commented Nov 20, 2024

View reviewed changes

src/libraries/Microsoft.PowerFx.Connectors/Tabular/Capabilities/ComplexColumnCapabilities.cs Show resolved Hide resolved

LucGenetier commented Nov 20, 2024

View reviewed changes

src/libraries/Microsoft.PowerFx.Core/Public/Values/CompileTimeTypeWrapperRecordValue.cs Show resolved Hide resolved