Simpler version.

microsoft · Mar 7, 2024 · 4615869 · 4615869
1 parent b7cb42b
commit 4615869
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 10 deletions.
diff --git a/src/libraries/Microsoft.PowerFx.Core/Binding/Binder.cs b/src/libraries/Microsoft.PowerFx.Core/Binding/Binder.cs
@@ -2882,10 +2882,7 @@ public override void Visit(FirstNameNode node)
                 }
                 else if (lookupInfo.Kind == BindKind.ScopeCollection)
                 {
-                    if (lookupInfo.Data is IExternalDataSource ds)
-                    {
-                        _txb.SetMutable(node, ds.IsWritable);
-                    }
+                    _txb.SetMutable(node, true);
                 }
 
                 Contracts.Assert(lookupInfo.Kind != BindKind.LambdaField);

diff --git a/src/libraries/Microsoft.PowerFx.Core/Entities/External/IExternalDataSource.cs b/src/libraries/Microsoft.PowerFx.Core/Entities/External/IExternalDataSource.cs
@@ -19,8 +19,6 @@ internal interface IExternalDataSource : IExternalEntity, IExternalPageableSymbo
 
         bool RequiresAsync { get; }
 
-        bool IsWritable { get; }
-
         IExternalDataEntityMetadataProvider DataEntityMetadataProvider { get; }
 
         DataSourceKind Kind { get; }

diff --git a/src/tests/Microsoft.PowerFx.Core.Tests/AssociatedDataSourcesTests/TestDVEntity.cs b/src/tests/Microsoft.PowerFx.Core.Tests/AssociatedDataSourcesTests/TestDVEntity.cs
@@ -29,8 +29,6 @@ public class AccountsEntity : IExternalEntity, IExternalDataSource
 
         public bool IsPageable => true;
 
-        public bool IsWritable => true;
-
         DType IExternalEntity.Type => AccountsTypeHelper.GetDType();
 
         IExternalDataEntityMetadataProvider IExternalDataSource.DataEntityMetadataProvider => throw new NotImplementedException();

diff --git a/src/tests/Microsoft.PowerFx.Core.Tests/Helpers/TestTabularDataSource.cs b/src/tests/Microsoft.PowerFx.Core.Tests/Helpers/TestTabularDataSource.cs
@@ -218,8 +218,6 @@ internal TestDataSource(string name, DType schema, string[] keyColumns = null, I
 
         IDelegationMetadata IExternalDataSource.DelegationMetadata => DelegationMetadata;
 
-        public bool IsWritable => throw new NotImplementedException();
-
         public bool CanIncludeExpand(IExpandInfo expandToAdd)
         {
             throw new NotImplementedException();