Enable audio support in MRVC #268
Conversation
binxie33
commented
Apr 28, 2018
binxie33
commented
- use the new SendBundleAsyncSequenced so the data buffers won't be sent out of sequence
- enable audio capture and streaming
…t of sequence 2. enable audio capture and streaming
| @@ -48,7 +48,7 @@ public Capture() | |||
|
|
|||
| private async void StartCapture() | |||
| { | |||
| captureEngine = await CaptureEngine.CreateAsync(false); | |||
| captureEngine = await CaptureEngine.CreateAsync(true); | |||
There was a problem hiding this comment.
change function signature to pass in the bool value for audio
There was a problem hiding this comment.
Sorry for the late response. Just got a chance to revisit this project. Added a checkbox in the UI and changed the signature of StartCapture. Please check the latest commit.
| @@ -434,6 +434,121 @@ HRESULT ConnectionImpl::SendBundleAsync( | |||
| return spWriteAction.CopyTo(sendAction); | |||
| } | |||
|
|
|||
| _Use_decl_annotations_ | |||
| HRESULT ConnectionImpl::SendBundleAsyncSequenced( | |||
There was a problem hiding this comment.
can the single buffer/bundle be refactored to use SendBundleAsync function so there is only one function that is possibly writing to the output stream of the socket
There was a problem hiding this comment.
Done. Removed the SendBundleAsyncSequenced function and refactor its code into the original function SendBundleAsync. Please check the latest commit.
…tartCapture 2. refactor the single buffer into SendBundleAsync
|
Does the audio work with the code changes? @binxie33 |
