Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] ignore ruff-format changes in git blame (fixes #6304) #6345

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Feb 28, 2024

Fixes #6304.

Adds the recent ruff-format commits to a .git-blame-ignore-revs file, so those changes that touched a LOT of lines are ignored in the git blame.

For details on that, see https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view

How I tested this

Look at the blame view on this branch: https://github.com/microsoft/LightGBM/blame/git-blame-ignore/python-package/lightgbm/basic.py.

Screen Shot 2024-02-27 at 10 03 17 PM

Scrolled through there and did not see any of the formatting changes in the blame.

Copy link
Collaborator

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know this feature yet, very useful! 😱

@jameslamb jameslamb merged commit 1a292f8 into master Feb 29, 2024
43 checks passed
@jameslamb jameslamb deleted the git-blame-ignore branch February 29, 2024 05:30
Copy link

github-actions bot commented Mar 6, 2025

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] [python-package] use black for formatting Python code?
3 participants