fix(ci): Disable jest cache for app-insights-logger tests #20037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've seen a few instances of these jest tests failing in CI pipeline runs (e.g. here and here; msft internal), where the process seemingly crashes (no jest output). Locally, this reproduces for me every single time.
Investigation led me to this which made my local runs pass consistently. The issue seems to be with
--experimental-vm-modules(they're still experimental, after all). At the end of that thread this node issue is referenced, which is fixed but the fix did not make it into Node20. When we move to Node21+ we might be able to remove this workaround.Note: since these are the only tests that use
--experimental-vm-modules(because they're the only ones which exercise a code path where we do a dynamicimport(), if I recall correctly) I don't expect other jest tests in the repo to require the same workaround.Reviewer Guidance
The review process is outlined on this wiki page.