fix: Fixed bug where group folds and sample weights couldn't be used together #1405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Previously there was an error with using sample weights and group folds together (see related issue). This PR fixes that issue, and adds a test to ensure that this stays fixed in future. I also noticed that we were importing
numpy
twice withintest_splits.py
, so I removed the defunct import statement.Related issue number
Closes #1396
Checks