Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed bug where group folds and sample weights couldn't be used together #1405

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dannycg1996
Copy link
Collaborator

@dannycg1996 dannycg1996 commented Feb 11, 2025

Why are these changes needed?

Previously there was an error with using sample weights and group folds together (see related issue). This PR fixes that issue, and adds a test to ensure that this stays fixed in future. I also noticed that we were importing numpy twice within test_splits.py, so I removed the defunct import statement.

Related issue number

Closes #1396

Checks

@dannycg1996 dannycg1996 requested a review from thinkall February 11, 2025 11:40
@dannycg1996
Copy link
Collaborator Author

Hi @thinkall,
All of the tests seem to pass, except for those on the ubuntu 3.10 and ubuntu 3.11 builds, where test_gpu fails. Having looked at some of the other open PRs, such as #1402 and #1392, it seems that this test always fails.
Is this a test we can just ignore? If not, do you have any ideas on how to fix it?
Thanks for any help!

@thinkall thinkall mentioned this pull request Feb 12, 2025
4 tasks
Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dannycg1996 for the PR! LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot Use GroupFolds With Sample Weights
2 participants