Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable syslog collection for cosmic #1282

Merged
merged 7 commits into from
Jun 20, 2024

Conversation

pfrcks
Copy link
Contributor

@pfrcks pfrcks commented Jun 19, 2024

This pull request mainly focuses on improving the logging and security aspects of the codebase. The most significant changes include the addition of new CVEs to the .trivyignore file, modifications to the livenessprobe.sh script that improve the handling of syslog status, and updates to the ama-logs.yaml and main.sh files in the kubernetes directory that enhance the configuration of the logging system.

Security improvements:

  • .trivyignore: Added new CVEs (CVE-2024-24790 and CVE-2024-24789) to the ignore list. This is a security measure to prevent the system from being affected by these vulnerabilities.

Logging improvements:

  • build/linux/installer/scripts/livenessprobe.sh: The conditional logic for handling the syslog status has been revised. The new code checks if the CONTROLLER_TYPE is a DaemonSet and then handles the syslog status differently based on the CONTAINER_TYPE and GENEVA_LOGS_INTEGRATION values. [1] [2]
  • kubernetes/ama-logs.yaml: Added SYSLOG_HOST_PORT to the environment variables and a new mount path. These changes provide additional configuration options for the logging system. [1] [2]
  • kubernetes/linux/main.sh: Various changes have been made to handle different scenarios based on the CONTAINER_TYPE, GENEVA_LOGS_INTEGRATION, and SYSLOG_HOST_PORT values. These changes improve the flexibility of the logging system and its integration with other services. [1] [2] [3] [4]

@pfrcks pfrcks requested a review from a team as a code owner June 19, 2024 19:49
ganga1980
ganga1980 previously approved these changes Jun 20, 2024
kubernetes/linux/main.sh Outdated Show resolved Hide resolved
@pfrcks pfrcks enabled auto-merge (squash) June 20, 2024 16:28
@pfrcks pfrcks merged commit 1980786 into ci_prod Jun 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants