Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable custom metrics #1260

Merged
merged 15 commits into from
May 23, 2024
Merged

disable custom metrics #1260

merged 15 commits into from
May 23, 2024

Conversation

pfrcks
Copy link
Contributor

@pfrcks pfrcks commented May 21, 2024

This pull request primarily introduces the ability to enable custom metrics in the system. It also makes adjustments to the conditions under which resource optimization is performed and modifies several configuration files.

The key changes are as follows:

Environment Variable Introduction:

Condition Modification:

Disabling Resource Optimization:

Custom Metrics Enabling:

Configuration File Changes:

  • build/linux/installer/conf/container-cm.conf, build/linux/installer/conf/kube-cm.conf: Added new configurations for custom metrics. [1] [2]
  • build/linux/installer/conf/container.conf, build/linux/installer/conf/kube.conf: Removed configurations related to custom metrics. [1] [2] [3] [4] [5] [6]

@pfrcks pfrcks requested a review from a team as a code owner May 21, 2024 06:28
@pfrcks
Copy link
Contributor Author

pfrcks commented May 22, 2024

@ganga1980 Do I need the changes in charts/azuremonitor-containers in charts/azuremonitor-containers-geneva as well?

build/linux/installer/conf/kube-cm.conf Show resolved Hide resolved
kubernetes/windows/main.ps1 Outdated Show resolved Hide resolved
kubernetes/windows/main.ps1 Outdated Show resolved Hide resolved
@ganga1980
Copy link
Contributor

@ganga1980 Do I need the changes in charts/azuremonitor-containers in charts/azuremonitor-containers-geneva as well?

no, we dont need.

@pfrcks
Copy link
Contributor Author

pfrcks commented May 23, 2024

  1. Tested MSI and Legacy Mode
  2. Tested enablement of custom metrics via cm
  3. Tested updated livenessprobe functionality of windows by manually stopping fluentd in normal scenarios
  4. Tested fluentd presence on windows for legacy mode and absence for msi mode

All comparison in order -> image with disabled custom metrics followed by image 3.1.20

MSI Linux DS MEM
msi-linux-ds-mem

MSI Linux DS CPU
msi-linux-ds-cpu

MSI Linux RS MEM
msi-linux-rs-mem

MSI Linux RS CPU
msi-linux-rs-cpu

MSI Windows DS WorkingSet Bytes
msi-windows-ds-mem-workingset

MSI Windows DS CPU
msi-windows-ds-cpu

Legacy DS MEM
legacy-linux-ds-mem

Legacy DS CPU
legacy-linux-ds-cpu

Legacy RS MEM
legacy-linux-rs-mem

Legacy RS CPU
legacy-linux-rs-cpu

Legacy Windows WorkingSet
legacy-windows-ds-mem-workingset

Legacy Windows CPU
legacy-windows-ds-cpu

Major improvement in Windows platform for both Legacy and MSI (30 MB improvement in Legacy vs 125 MB improvement in MSI)
Minor improvement in RS for both Legacy and MSI
Similar values in DS for both Legacy and MSI

kubernetes/linux/main.sh Show resolved Hide resolved
kubernetes/linux/main.sh Show resolved Hide resolved
kubernetes/linux/main.sh Show resolved Hide resolved
@pfrcks pfrcks enabled auto-merge (squash) May 23, 2024 23:40
@pfrcks pfrcks merged commit d539909 into ci_prod May 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants