-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable custom metrics #1260
Merged
Merged
disable custom metrics #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ganga1980 Do I need the changes in charts/azuremonitor-containers in charts/azuremonitor-containers-geneva as well? |
ganga1980
reviewed
May 22, 2024
ganga1980
reviewed
May 22, 2024
jatakiajanvi12
suggested changes
May 22, 2024
no, we dont need. |
ganga1980
reviewed
May 23, 2024
jatakiajanvi12
suggested changes
May 23, 2024
ganga1980
reviewed
May 23, 2024
ganga1980
reviewed
May 23, 2024
ganga1980
reviewed
May 23, 2024
ganga1980
approved these changes
May 23, 2024
jatakiajanvi12
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily introduces the ability to enable custom metrics in the system. It also makes adjustments to the conditions under which resource optimization is performed and modifies several configuration files.
The key changes are as follows:
Environment Variable Introduction:
build/common/installer/scripts/fluent-bit-conf-customizer.rb
: Introduced a new environment variableENABLE_CUSTOM_METRICS
to enable or disable custom metrics.Condition Modification:
build/common/installer/scripts/fluent-bit-conf-customizer.rb
: Modified the condition for resource optimization. Now, resource optimization will be performed if the system is Linux and custom metrics are not enabled, or if the system is Windows and Fluent Bit is not disabled.Disabling Resource Optimization:
build/common/installer/scripts/tomlparser-agent-config.rb
: If custom metrics are enabled, resource optimization is disabled.Custom Metrics Enabling:
build/common/installer/scripts/tomlparser-common-agent-config.rb
: Added the ability to enable custom metrics through the parsed configuration.Configuration File Changes:
build/linux/installer/conf/container-cm.conf
,build/linux/installer/conf/kube-cm.conf
: Added new configurations for custom metrics. [1] [2]build/linux/installer/conf/container.conf
,build/linux/installer/conf/kube.conf
: Removed configurations related to custom metrics. [1] [2] [3] [4] [5] [6]