Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing validation error on DS compilation with no patch constant signature #6629

Open
jenatali opened this issue May 15, 2024 · 0 comments
Open
Labels
bug Bug, regression, crash validation Related to validation or signing

Comments

@jenatali
Copy link
Member

Description
D3D12 shader linkages require identical declarations of the patch constant signature between HS and DS. Since HS must output tessellation levels, DS must therefore input them. FXC had such an error:

error X3502: ds_5_0 tessfactor inputs missing

Steps to Reproduce

[domain("tri")]
float4 DSMain(float4 pos : POS) : SV_Position
{
	return pos;
}

Compile with FXC target ds_5_0 and you get error X3502. DXC succeeds. Attempting to use such a shader results in a D3D12 PSO creation failure (E_FAIL) with no debug layer error message (D3D bug 50951962 is tracking this missing error message).

See https://godbolt.org/z/5bs15vx4s for DXC on trunk, and https://shader-playground.timjones.io/3b46dc2f059f0b0611dcf44c264ccaab for FXC.

Environment

  • DXC version: dxc(private) 1.8.0.10001 (main, ff623f8a)
@jenatali jenatali added bug Bug, regression, crash needs-triage Awaiting triage labels May 15, 2024
@damyanp damyanp added validation Related to validation or signing and removed needs-triage Awaiting triage labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug, regression, crash validation Related to validation or signing
Projects
Status: Triaged
Development

No branches or pull requests

2 participants