Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error caused by all_reduce call in domino #6880

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

hwchen2017
Copy link
Contributor

@hwchen2017 hwchen2017 commented Dec 16, 2024

Fix #6851
Initialize communication backend to fix error caused by all_reduce call in the Domino transformer layer.
Verified correctness in local test.

Copy link
Member

@GuanhuaWang GuanhuaWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @hwchen2017 please find comments

deepspeed/runtime/domino/transformer.py Outdated Show resolved Hide resolved
@hwchen2017
Copy link
Contributor Author

@hwchen2017 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement
@microsoft-github-policy-service agree

@GuanhuaWang
Copy link
Member

let's see if the OOM error still exists in our CI test nv-torch-latest-v100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUESTIONS]:Some questions about running Domino
4 participants