Refactored and added new tests and data for Date, GroupBy operations, Value functions and other scenarios #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Value functions and other scenarios - Implemented GroupByWithListAverage query to calculate average LocationID by Borough. - Added output for GroupByWithListAverage to validate results. - Created GroupByWithListMinMax query to find max and min values for Zone and LocationID by Borough. - Added output for GroupByWithListMinMax to validate results. - Developed GroupByWithListMinMaxDateTime query to find max and min pickup datetime by PULocationID. - Added output for GroupByWithListMinMaxDateTime to validate results. - Implemented GroupByWithTableRunCount query to count occurrences of Zones. - Added output for GroupByWithTableRunCount to validate results. - Created ValueFunctions query to test various mathematical operations on passenger_count and total_amount. - Added output for ValueFunctions to validate results.
…y example to include NycTaxiGreenDate
alokdeorani
reviewed
Jun 15, 2025
There was a problem hiding this comment.
Can we just have Table.FirstN(table,1) for these kind of scenarios. It is hard to figure out whats in pqout file.
There was a problem hiding this comment.
The output is larger for only NoSkipTake which is expected. There are 3 options - Leave it as is, reduce the source table to from 264 to something smaller like 5 rows or just do a rowcount comparison. Any suggestions?
alokdeorani
reviewed
Jun 15, 2025
There was a problem hiding this comment.
Same applies here and some other scenarios. Table.FirstN is what we should use.
There was a problem hiding this comment.
I'll check and address and other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored and added new tests and data as below: