unittest: Allow SkipTest to work within a subTest. #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, the new location for the skip check makes far more sense in general really. The test results are visible in CI. |
andrewleech
approved these changes
Nov 6, 2024
Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
dpgeorge
force-pushed
the
unittest-skip-subtest
branch
from
d0840ac to
0104788
Compare
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors things slightly so that
SkipTestexceptions are handled correctly within a sub-test context manager.Also enabled
unittesttests on CI.