Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usb-device-keyboard: Fix ; and ` keycode names. #889

Merged

Conversation

dpgeorge
Copy link
Member

@dpgeorge dpgeorge commented Jul 3, 2024

They should be named as the un-shifted version.

They should be named as the un-shifted version.

Signed-off-by: Damien George <[email protected]>
@dpgeorge
Copy link
Member Author

dpgeorge commented Jul 3, 2024

@projectgus FYI

@projectgus
Copy link
Contributor

LGTM! I double checked the USB "HID Usages and Descriptions" document (section 10
"Keyboard/Keypad Page (0x07)") and it describes them as "Keyboard ; and :" and "Keyboard Grave Accent and Tilde", so this is the right fix.

@dpgeorge dpgeorge merged commit fbf7e12 into micropython:master Jul 5, 2024
4 checks passed
@dpgeorge dpgeorge deleted the usb-keyboard-fix-keycode-names branch July 5, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants