Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uaiohttpclient: parse port instead of hard code 80 #764

Merged
merged 4 commits into from
Dec 20, 2023
Merged

uaiohttpclient: parse port instead of hard code 80 #764

merged 4 commits into from
Dec 20, 2023

Conversation

bulletmark
Copy link
Contributor

I was getting an error using uaiohttpclient and it was due to it hard coding port 80 for the target host. This PR makes a trivial change to split host:port if present in the URL. I thought it also sensible to update all the yield from to await everywhere and of course preface those functions async. I made a couple of other minor changes which were suggested by ruff and flake8, i.e. a variable l I changed to ln and there was a comment > 80 chars which I wrapped.

@bulletmark
Copy link
Contributor Author

Although trivial, I have changed this PR from 1 commit into 4 separate commits because they are logically distinct changes and this makes it easier to review. I can also easily remove or squash any commits you request.

@dpgeorge
Copy link
Member

Thank you, this is a good fix for the port number, and also a nice clean up with the other commits. And thanks also for splitting the commits into logical changes.

@dpgeorge dpgeorge merged commit 9ceda53 into micropython:master Dec 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants