logging: Allow logging.exception helper to handle tracebacks. #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgeorge
reviewed
Jun 5, 2025
python-stdlib/logging/logging.py
Outdated
| @@ -202,8 +202,8 @@ def critical(msg, *args): | |||
| getLogger().critical(msg, *args) | |||
|
|
|||
|
|
|||
| def exception(msg, *args): | |||
| getLogger().exception(msg, *args) | |||
| def exception(msg, *args, **kwargs): | |||
There was a problem hiding this comment.
Would it be better to do:
def exception(msg, *args, exc_info=True):
getLogger().exception(msg, *args, exc_info)?
That way it's clear what args are supported. In particular, general keyword args are not supported, only exc_info is.
There was a problem hiding this comment.
Good idea; I've updated it!
dpgeorge
approved these changes
Jun 6, 2025
Although `Logger.exception` supports passing exception info with `exc_info`, when you use `logging.exception` keyword arguments are not forwarded to the root logger, which makes passing `exc_info` raise `TypeError`. Signed-off-by: Nick Budak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
Logger.exceptionsupports passing exception info withexc_info, when you uselogging.exception, keyword arguments are not forwarded to the root logger, which makes passingexc_inforaise TypeError.