Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Groovy source file implementation #9968

Draft
wants to merge 1 commit into
base: 4.2.x
Choose a base branch
from
Draft

Add missing Groovy source file implementation #9968

wants to merge 1 commit into from

Conversation

dstepanov
Copy link
Contributor

No description provided.

melix
melix approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked the behavior? Won't this generate source files in the classes directory, so alongside the .class files?

@dstepanov dstepanov marked this pull request as draft October 11, 2023 15:36
@graemerocher
Copy link
Contributor

probably we need a test, and also just realised there are no tests for the other languages

@graemerocher
Copy link
Contributor

also what happens KAPT vs KSP

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melix melix melix approved these changes

@graemerocher graemerocher Awaiting requested review from graemerocher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dstepanov @graemerocher @melix